PostTask MaybeReleaseAdapter in BluetoothEventRouter::AdapterDiscoveringChanged

PostTask MaybeReleaseAdapter in BluetoothEventRouter::AdapterDiscoveringChanged

Calling MaybeReleaseAdapter directly from
BluetoothEventRouter::AdapterDiscoveringChanged could be a problem since
this can happen:
BluetoothAdapterBlueZ::AdapterPropertyChanged ->
BluetoothAdapterBlueZ::DiscoveringChanged ->
BluetoothEventRouter::AdapterDiscoveringChanged -> MaybeReleaseAdapter

If BluetoothEventRouter is the only pointer holder left then the caller
of BluetoothEventRouter::AdapterDiscoveringChanged could be gone even
before that function returns.

BUG=710216
Review-Url: https://codereview.chromium.org/2852773002
Cr-Commit-Position: refs/heads/master@{#468180}
Committed: https://chromium.googlesource.com/chromium/src/+/518c599b12849fb5ca778427c877c2250d116455

[Sonny Sasaka, 2017-04-28 19:51:40]

The CQ bit was checked by sonnysasaka@chromium.org to run a CQ dry run

[Sonny Sasaka, 2017-04-28 19:52:34]

Description was changed from

==========
PostTask MaybeReleaseAdapter in BluetoothEventRouter::AdapterDiscoveringChanged

Calling MaybeReleaseAdapter directly from
BluetoothEventRouter::AdapterDiscoveringChanged could be a problem since
this can happen:
BluetoothAdapterBlueZ::AdapterPropertyChanged ->
BluetoothAdapterBlueZ::DiscoveringChanged ->
BluetoothEventRouter::AdapterDiscoveringChanged -> MaybeReleaseAdapter

If BluetoothEventRouter is the only pointer holder left then the caller
of BluetoothEventRouter::AdapterDiscoveringChanged could be gone even
before that function returns.

BUG=710216
==========

to

==========
PostTask MaybeReleaseAdapter in BluetoothEventRouter::AdapterDiscoveringChanged

Calling MaybeReleaseAdapter directly from
BluetoothEventRouter::AdapterDiscoveringChanged could be a problem since
this can happen:
BluetoothAdapterBlueZ::AdapterPropertyChanged ->
BluetoothAdapterBlueZ::DiscoveringChanged ->
BluetoothEventRouter::AdapterDiscoveringChanged -> MaybeReleaseAdapter

If BluetoothEventRouter is the only pointer holder left then the caller
of BluetoothEventRouter::AdapterDiscoveringChanged could be gone even
before that function returns.

BUG=710216
==========

[Sonny Sasaka, 2017-04-28 19:52:34]

sonnysasaka@chromium.org changed reviewers:
+ stevenjb@chromium.org

[commit-bot: I haz the power, 2017-04-28 19:52:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 21:52:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:52:17]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-04-28 23:03:45]

This lgtm because I am pretty sure this is safer than the current code, but I'm
not entirely convinced this completely solves our reference problems in this
code.

[Sonny Sasaka, 2017-04-28 23:24:17]

The CQ bit was checked by sonnysasaka@chromium.org

[commit-bot: I haz the power, 2017-04-28 23:24:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 23:34:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493421857349950, "parent_rev":
"b399a05453d7b3e2dfdec67865fefe6953bcc59e", "commit_rev":
"518c599b12849fb5ca778427c877c2250d116455"}

[commit-bot: I haz the power, 2017-04-28 23:34:42]

Description was changed from

==========
PostTask MaybeReleaseAdapter in BluetoothEventRouter::AdapterDiscoveringChanged

Calling MaybeReleaseAdapter directly from
BluetoothEventRouter::AdapterDiscoveringChanged could be a problem since
this can happen:
BluetoothAdapterBlueZ::AdapterPropertyChanged ->
BluetoothAdapterBlueZ::DiscoveringChanged ->
BluetoothEventRouter::AdapterDiscoveringChanged -> MaybeReleaseAdapter

If BluetoothEventRouter is the only pointer holder left then the caller
of BluetoothEventRouter::AdapterDiscoveringChanged could be gone even
before that function returns.

BUG=710216
==========

to

==========
PostTask MaybeReleaseAdapter in BluetoothEventRouter::AdapterDiscoveringChanged

Calling MaybeReleaseAdapter directly from
BluetoothEventRouter::AdapterDiscoveringChanged could be a problem since
this can happen:
BluetoothAdapterBlueZ::AdapterPropertyChanged ->
BluetoothAdapterBlueZ::DiscoveringChanged ->
BluetoothEventRouter::AdapterDiscoveringChanged -> MaybeReleaseAdapter

If BluetoothEventRouter is the only pointer holder left then the caller
of BluetoothEventRouter::AdapterDiscoveringChanged could be gone even
before that function returns.

BUG=710216

Review-Url: https://codereview.chromium.org/2852773002
Cr-Commit-Position: refs/heads/master@{#468180}
Committed:
https://chromium.googlesource.com/chromium/src/+/518c599b12849fb5ca778427c877...
==========

[commit-bot: I haz the power, 2017-04-28 23:34:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/518c599b12849fb5ca778427c877...