Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2865303003: Remove a non-existent method declaration. (Closed)

Created:
3 years, 7 months ago by davidben
Modified:
3 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a non-existent method declaration. The method was removed in https://codereview.chromium.org/193663003 but not the declaration. Also make P2PSocketClient's constructor protected like the destructor as there is no way to create it without subclassing anyway. BUG=none Review-Url: https://codereview.chromium.org/2865303003 Cr-Commit-Position: refs/heads/master@{#472241} Committed: https://chromium.googlesource.com/chromium/src/+/a8a710afa4d7e6c81a15f9fe73d562e8fb895fe9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M content/renderer/p2p/socket_client.h View 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
davidben
Noticed this idly.
3 years, 7 months ago (2017-05-09 20:47:38 UTC) #6
Sergey Ulanov
lgtm
3 years, 7 months ago (2017-05-16 19:32:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865303003/1
3 years, 7 months ago (2017-05-16 20:00:25 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 23:09:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8a710afa4d7e6c81a15f9fe73d5...

Powered by Google App Engine
This is Rietveld 408576698