Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 193663003: Push remote hostname to P2P socket host. (Closed)

Created:
6 years, 9 months ago by Mallinath (Gone from Chromium)
Modified:
6 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org
Visibility:
Public.

Description

Push remote hostname to P2P socket host. Currently P2P Socket hosts only get resolved address of the target host. But if the remote is connected through TLS, we may need to use remote hostname for the certificate. This CL will use remote hostname for TLS if available. BUG=306285 R=sergeyu@chromium.org TBR=cevans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256496

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -60 lines) Patch
M content/browser/renderer_host/p2p/socket_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc View 11 chunks +21 lines, -24 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/p2p_messages.h View 3 chunks +6 lines, -2 lines 0 comments Download
M content/common/p2p_socket_type.h View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 1 chunk +6 lines, -1 line 0 comments Download
M content/renderer/p2p/socket_client_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/socket_client_impl.cc View 1 3 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mallinath (Gone from Chromium)
6 years, 9 months ago (2014-03-11 00:52:53 UTC) #1
Sergey Ulanov
lgtm https://codereview.chromium.org/193663003/diff/20001/content/common/p2p_socket_type.h File content/common/p2p_socket_type.h (right): https://codereview.chromium.org/193663003/diff/20001/content/common/p2p_socket_type.h#newcode10 content/common/p2p_socket_type.h:10: also need to include <string> here
6 years, 9 months ago (2014-03-11 22:02:16 UTC) #2
Mallinath (Gone from Chromium)
https://codereview.chromium.org/193663003/diff/20001/content/common/p2p_socket_type.h File content/common/p2p_socket_type.h (right): https://codereview.chromium.org/193663003/diff/20001/content/common/p2p_socket_type.h#newcode10 content/common/p2p_socket_type.h:10: On 2014/03/11 22:02:16, Sergey Ulanov wrote: > also need ...
6 years, 9 months ago (2014-03-11 22:31:03 UTC) #3
Mallinath (Gone from Chromium)
The CQ bit was checked by mallinath@chromium.org
6 years, 9 months ago (2014-03-11 22:42:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mallinath@chromium.org/193663003/30001
6 years, 9 months ago (2014-03-11 22:52:21 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 09:54:07 UTC) #6
Message was sent while issue was closed. 
Change committed as 256496

Powered by Google App Engine
This is Rietveld 408576698