Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2865183002:
Update Android payment app parameters. (Closed)
|
Created:
3 years, 7 months ago by please use gerrit instead Modified:
3 years, 7 months ago Reviewers:
gogerald1 CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, agrieve+watch_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate Android payment app parameters.
Changed parameter names:
dataMap ---> methodData
origin ---> topLevelOrigin
iframeOrigin ---> paymentRequestOrigin
certificateChain ---> topLevelCertificateChain
id ---> paymentRequestId
instrumentDetails ---> details
The old parameter names are still used for backward compatibility.
Android payment app spec:
https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE
The new parameter names are meant to closely resemble the
PaymentRequestevent in the payment handler spec:
https://w3c.github.io/webpayments-payment-handler/#the-paymentrequestevent
BUG=620173
Review-Url: https://codereview.chromium.org/2865183002
Cr-Commit-Position: refs/heads/master@{#470568}
Committed: https://chromium.googlesource.com/chromium/src/+/23b9ba1340ee76f7ef9d6b8b61218f833e6f79e0
Patch Set 1 #
Total comments: 2
Patch Set 2 : details #
Dependent Patchsets: Messages
Total messages: 24 (16 generated)
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Description was changed from ========== Update Android payment app parameters. Changed parameter names: dataMap ---> methodData origin ---> topLevelOrigin iframeOrigin ---> paymentRequestOrigin certificateChain ---> topLevelCertificateChain id ---> paymentRequestId The old parameter names are still used for backward compatibility. Spec: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE BUG=620173 ========== to ========== Update Android payment app parameters. Changed parameter names: dataMap ---> methodData origin ---> topLevelOrigin iframeOrigin ---> paymentRequestOrigin certificateChain ---> topLevelCertificateChain id ---> paymentRequestId The old parameter names are still used for backward compatibility. Android payment app spec: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE The new parameter names are meant to closely resemble the PaymentRequestevent in the payment handler spec: https://w3c.github.io/webpayments-payment-handler/#the-paymentrequestevent BUG=620173 ==========
rouslan@chromium.org changed reviewers: + gogerald@chromium.org
Ganggui, ptal.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with a nit https://codereview.chromium.org/2865183002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java (right): https://codereview.chromium.org/2865183002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:84: private static final String EXTRA_RESPONSE_INSTRUMENT_DETAILS = "instrumentDetails"; nit: This is 'details' to be exact the same as in PaymentAppResponse
Sending to cq. https://codereview.chromium.org/2865183002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java (right): https://codereview.chromium.org/2865183002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:84: private static final String EXTRA_RESPONSE_INSTRUMENT_DETAILS = "instrumentDetails"; On 2017/05/09 18:26:49, gogerald1 wrote: > nit: This is 'details' to be exact the same as in PaymentAppResponse Done.
The CQ bit was checked by rouslan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gogerald@chromium.org Link to the patchset: https://codereview.chromium.org/2865183002/#ps40001 (title: "details")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by rouslan@chromium.org
Description was changed from ========== Update Android payment app parameters. Changed parameter names: dataMap ---> methodData origin ---> topLevelOrigin iframeOrigin ---> paymentRequestOrigin certificateChain ---> topLevelCertificateChain id ---> paymentRequestId The old parameter names are still used for backward compatibility. Android payment app spec: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE The new parameter names are meant to closely resemble the PaymentRequestevent in the payment handler spec: https://w3c.github.io/webpayments-payment-handler/#the-paymentrequestevent BUG=620173 ========== to ========== Update Android payment app parameters. Changed parameter names: dataMap ---> methodData origin ---> topLevelOrigin iframeOrigin ---> paymentRequestOrigin certificateChain ---> topLevelCertificateChain id ---> paymentRequestId instrumentDetails ---> details The old parameter names are still used for backward compatibility. Android payment app spec: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE The new parameter names are meant to closely resemble the PaymentRequestevent in the payment handler spec: https://w3c.github.io/webpayments-payment-handler/#the-paymentrequestevent BUG=620173 ==========
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494425475264430,
"parent_rev": "6e66e1c2bd52b4790d7899535c77f13c3a5cc499", "commit_rev":
"23b9ba1340ee76f7ef9d6b8b61218f833e6f79e0"}
Message was sent while issue was closed.
Description was changed from ========== Update Android payment app parameters. Changed parameter names: dataMap ---> methodData origin ---> topLevelOrigin iframeOrigin ---> paymentRequestOrigin certificateChain ---> topLevelCertificateChain id ---> paymentRequestId instrumentDetails ---> details The old parameter names are still used for backward compatibility. Android payment app spec: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE The new parameter names are meant to closely resemble the PaymentRequestevent in the payment handler spec: https://w3c.github.io/webpayments-payment-handler/#the-paymentrequestevent BUG=620173 ========== to ========== Update Android payment app parameters. Changed parameter names: dataMap ---> methodData origin ---> topLevelOrigin iframeOrigin ---> paymentRequestOrigin certificateChain ---> topLevelCertificateChain id ---> paymentRequestId instrumentDetails ---> details The old parameter names are still used for backward compatibility. Android payment app spec: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE The new parameter names are meant to closely resemble the PaymentRequestevent in the payment handler spec: https://w3c.github.io/webpayments-payment-handler/#the-paymentrequestevent BUG=620173 Review-Url: https://codereview.chromium.org/2865183002 Cr-Commit-Position: refs/heads/master@{#470568} Committed: https://chromium.googlesource.com/chromium/src/+/23b9ba1340ee76f7ef9d6b8b6121... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/23b9ba1340ee76f7ef9d6b8b6121... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
