Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2873503006: Pass "total" to IS_READY_TO_PAY service. (Closed)

Created:
3 years, 7 months ago by please use gerrit instead
Modified:
3 years, 7 months ago
Reviewers:
gogerald1
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, agrieve+watch_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass "total" to IS_READY_TO_PAY service. Before this patch, a PaymentRequest for USD $100.00 would show all available payment apps in Chrome UI, even if some of the apps do not carry enough balance. This patch adds a "total" parameter to IS_READY_TO_PAY service. This parameter is JSON-stringified PaymentCurencyAmount. For example: {"currency": "USD", "value": "10.00"} After this patch, payment apps can decide to return "false" to IS_READY_TO_PAY query if they do not carry enough balance. These apps would not be available in Chrome UI when a PaymentRequest for too high of an amount is created. Spec: https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE BUG=620173 Review-Url: https://codereview.chromium.org/2873503006 Cr-Commit-Position: refs/heads/master@{#471081} Committed: https://chromium.googlesource.com/chromium/src/+/75a129138b5e1e7c08ab918c9e754ac4027f24c8

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 10 (6 generated)
please use gerrit instead
Ganggui, ptal.
3 years, 7 months ago (2017-05-11 15:25:20 UTC) #3
gogerald1
lgtm
3 years, 7 months ago (2017-05-11 20:14:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873503006/20001
3 years, 7 months ago (2017-05-11 20:34:18 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 21:48:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/75a129138b5e1e7c08ab918c9e75...

Powered by Google App Engine
This is Rietveld 408576698