Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 2865163003: EditorClientImpl changed to use WebLocalFrameBase instead of WebLocalFrameImpl. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

EditorClientImpl changed to use WebLocalFrameBase instead of WebLocalFrameImpl. This is a subset of https://codereview.chromium.org/2870773003 which did not work as there were link errors on WebFrameClient::FrameDetached on windows builds. In general now I think i will just try and move existing usages of WebLocalFrameImpl to WebLocalFrameBase as a first step, and then try to move files into core as a second step, once we have moved the basic types to core/exported (WebFrameClient, WebLocalFrame etc etc). BUG=712963 Review-Url: https://codereview.chromium.org/2865163003 Cr-Commit-Position: refs/heads/master@{#470257} Committed: https://chromium.googlesource.com/chromium/src/+/c08e365f4e2e5940d1632fd693573737f867ad6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/web/EditorClientImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
slangley
3 years, 7 months ago (2017-05-09 04:35:02 UTC) #2
haraken
LGTM
3 years, 7 months ago (2017-05-09 05:21:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865163003/1
3 years, 7 months ago (2017-05-09 05:22:29 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 07:03:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c08e365f4e2e5940d1632fd69357...

Powered by Google App Engine
This is Rietveld 408576698