Move EditorClientImpl.cpp out of web/ to core/page/EditorClient.cpp

Move EditorClientImpl.cpp out of web/ to core/page/EditorClient.cpp

EditClientImpl.cpp had a dependency on WebLocalFrameImpl, were were able to break
this using WebLocalFrameBase. As there were no other dependencies on web/ we
were then able to move the code to core/page and remove the EditClientImpl class
altogether.

BUG=712963

[slangley, 2017-05-08 23:33:09]

Description was changed from

==========
Move EditorClientImpl out of web/ to EditorClient.

BUG=
==========

to

==========
Move EditorClientImpl.cpp out of web/ to core/page/EditorClient.cpp

EditClientImpl.cpp had a dependency on WebLocalFrameImpl, were were able to
break
this using WebLocalFrameBase. As there were no other dependencies on web/ we
were then able to move the code to core/page and remove the EditClientImpl class
altogether.

BUG=712963
==========

[slangley, 2017-05-08 23:34:00]

slangley@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-05-08 23:51:38]

LGTM

https://codereview.chromium.org/2870773003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/EditorClient.cpp (right):

https://codereview.chromium.org/2870773003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/EditorClient.cpp:51:
web_view_->Client()->DidChangeContents();

Not directly related to this CL, it might be nicer to pass in LocalFrame* to
this method and get the WebViewBase by WebViewBase::FromPage(frame->GetPage()).
Then you don't need to store web_view_ on EditorClient.

If you need to store WebViewBase* in many places, you can consider that.

[slangley, 2017-05-09 00:23:18]

Thanks!

https://codereview.chromium.org/2870773003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/EditorClient.cpp (right):

https://codereview.chromium.org/2870773003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/EditorClient.cpp:51:
web_view_->Client()->DidChangeContents();
On 2017/05/08 at 23:51:38, haraken wrote:
> Not directly related to this CL, it might be nicer to pass in LocalFrame* to
this method and get the WebViewBase by WebViewBase::FromPage(frame->GetPage()).
Then you don't need to store web_view_ on EditorClient.
> 
> If you need to store WebViewBase* in many places, you can consider that.

Got it - I'll submit as is but keep this in mind. We can hopefully clean up many
places when we look at removing ChromeClient etc.

[slangley, 2017-05-09 00:23:22]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-09 00:29:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:59:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:59:04]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[slangley, 2017-05-09 04:22:06]

On 2017/05/09 at 01:59:04, commit-bot wrote:
> Try jobs failed on following builders:
>   win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

We cannot move EditorClientImpl as it has a dependency on
blink::WebFrameClient::FrameDetached() which is still in web/. Reverting this
patch.