Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2864783002: Upstream service wrkr `importScripts` tests to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, falken+watch_chromium.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tfarina, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service wrkr `importScripts` tests to WPT In order to contribute this test logic to the Web Platform Tests project, the invalid assertion it includes needed to be corrected. Because the test was previously formatted as a single sub-test, the resultant failure tended to obscure the results of assertions for independent conditions. Re-factor the test to support more fine-grained reporting, and white-list the specific failure as "allowed" in the Chromium build infrastructure. BUG=688116, 719052 R=mek@chromium.org Review-Url: https://codereview.chromium.org/2864783002 Cr-Commit-Position: refs/heads/master@{#470105} Committed: https://chromium.googlesource.com/chromium/src/+/e9f34ed893dd0ab15ac4834becee26c4886620d7

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -118 lines) Patch
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/import-scripts-resource-map.https.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/import-scripts-updated-flag.https.html View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/import-scripts-updated-flag.https-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/import-scripts-echo.py View 1 chunk +6 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/import-scripts-resource-map-worker.js View 1 chunk +5 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/import-scripts-updated-flag-worker.js View 2 chunks +11 lines, -8 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/import-scripts-version.py View 1 chunk +17 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/importScripts.html View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/duplicate-import-worker.js View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/echo.php View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/get-version.php View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/import-scripts-worker.js View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mike3
Hi Mek, I created bug 719052 to track the spec violation, but I can't find ...
3 years, 7 months ago (2017-05-05 22:18:49 UTC) #1
Marijn Kruisselbrink
On 2017/05/05 at 22:18:49, mike wrote: > I created bug 719052 to track the spec ...
3 years, 7 months ago (2017-05-06 00:08:50 UTC) #2
mike3
Thanks! https://codereview.chromium.org/2864783002/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/import-scripts-resource-map.https.html File third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/import-scripts-resource-map.https.html (right): https://codereview.chromium.org/2864783002/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/import-scripts-resource-map.https.html#newcode9 third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/import-scripts-resource-map.https.html:9: function post_and_wait_for_reply(worker, message) { On 2017/05/06 00:08:49, Marijn ...
3 years, 7 months ago (2017-05-08 18:49:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864783002/20001
3 years, 7 months ago (2017-05-08 18:50:33 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 20:26:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e9f34ed893dd0ab15ac4834becee...

Powered by Google App Engine
This is Rietveld 408576698