Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/import-scripts-updated-flag-worker.js

Issue 2864783002: Upstream service wrkr `importScripts` tests to WPT (Closed)
Patch Set: Incorporate review feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/import-scripts-updated-flag-worker.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/import-scripts-worker.js b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/import-scripts-updated-flag-worker.js
similarity index 50%
rename from third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/import-scripts-worker.js
rename to third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/import-scripts-updated-flag-worker.js
index c3c5fac92cd1364495cb67d6c10aa8cab3128053..0f5005d9af41d95c9243096478d2e35c653c9660 100644
--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/import-scripts-worker.js
+++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/import-scripts-updated-flag-worker.js
@@ -1,10 +1,10 @@
-importScripts('../../resources/testharness.js');
+importScripts('/resources/testharness.js');
let echo_output = null;
// Tests importing a script that sets |echo_output| to the query string.
function test_import(str) {
- importScripts('echo.php?' + str);
+ importScripts('import-scripts-echo.py?msg=' + str);
assert_equals(echo_output, str);
}
@@ -17,10 +17,13 @@ self.addEventListener('install', () => {
});
self.addEventListener('message', e => {
- test_import('root-and-message');
- test_import('install-and-message');
- // TODO(falken): This should fail. The spec disallows importing a non-cached
- // script like this but currently Chrome and Firefox allow it.
- test_import('message');
- e.source.postMessage('OK');
+ var error = null;
+
+ try {
+ importScripts('import-scripts-echo.py?msg=' + e.data);
+ } catch (e) {
+ error = e && e.name;
+ }
+
+ e.source.postMessage({ error: error, value: echo_output });
});

Powered by Google App Engine
This is Rietveld 408576698