Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2864603003: Implement and ship PushSubscription.expirationTime (Closed)

Created:
3 years, 7 months ago by Peter Beverloo
Modified:
3 years, 7 months ago
CC:
awdf+watch_chromium.org, blink-reviews, chromium-reviews, falken+watch_chromium.org, haraken, harkness+watch_chromium.org, horo+watch_chromium.org, johnme+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, Peter Beverloo, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement and ship PushSubscription.expirationTime This property tells developers the time after which the subscription will be deactivated, if any. Since we don't support refreshing subscriptions yet, it always returns NULL. Specification: https://w3c.github.io/push-api/#dom-pushsubscription-expirationtime Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/xCTqjIDrOm4/discussion BUG=718837 Review-Url: https://codereview.chromium.org/2864603003 Cr-Commit-Position: refs/heads/master@{#472886} Committed: https://chromium.googlesource.com/chromium/src/+/868006705aed11538a1402f4db46953e2cfe2a5a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Implement and ship PushSubscription.expirationTime #

Total comments: 2

Patch Set 3 : layout test fix #

Patch Set 4 : Implement and ship PushSubscription.expirationTime #

Patch Set 5 : rebase #

Patch Set 6 : mac results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/push_messaging/push-subscription-stringification.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/push_messaging/subscribe-success-in-document.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushSubscription.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 46 (32 generated)
Peter Beverloo
+johnme for push +jochen for webexposed tests
3 years, 7 months ago (2017-05-05 13:14:20 UTC) #5
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2864603003/diff/1/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp File third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp (right): https://codereview.chromium.org/2864603003/diff/1/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp#newcode49 third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp:49: DOMTimeStamp PushSubscription::expirationTime(bool& is_null) const { why not bool*?
3 years, 7 months ago (2017-05-05 14:35:42 UTC) #6
Peter Beverloo
https://codereview.chromium.org/2864603003/diff/1/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp File third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp (right): https://codereview.chromium.org/2864603003/diff/1/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp#newcode49 third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp:49: DOMTimeStamp PushSubscription::expirationTime(bool& is_null) const { On 2017/05/05 14:35:42, jochen ...
3 years, 7 months ago (2017-05-05 14:42:55 UTC) #7
jochen (gone - plz use gerrit)
ok, fair enough still waiting for the blink-dev thread to be resolved
3 years, 7 months ago (2017-05-08 06:18:11 UTC) #14
johnme
lgtm from push messaging POV https://codereview.chromium.org/2864603003/diff/20001/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h File third_party/WebKit/Source/modules/push_messaging/PushSubscription.h (right): https://codereview.chromium.org/2864603003/diff/20001/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h#newcode41 third_party/WebKit/Source/modules/push_messaging/PushSubscription.h:41: DOMTimeStamp expirationTime(bool& is_null) const; ...
3 years, 7 months ago (2017-05-08 12:06:10 UTC) #17
Peter Beverloo
https://codereview.chromium.org/2864603003/diff/20001/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h File third_party/WebKit/Source/modules/push_messaging/PushSubscription.h (right): https://codereview.chromium.org/2864603003/diff/20001/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h#newcode41 third_party/WebKit/Source/modules/push_messaging/PushSubscription.h:41: DOMTimeStamp expirationTime(bool& is_null) const; On 2017/05/08 12:06:10, johnme wrote: ...
3 years, 7 months ago (2017-05-08 14:42:37 UTC) #19
Peter Beverloo
jochen@ - PTAL at webexposed OWNERS here too, this passed as well. I'll rebase on ...
3 years, 7 months ago (2017-05-16 14:20:59 UTC) #23
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-16 14:25:22 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864603003/100001
3 years, 7 months ago (2017-05-17 12:13:43 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457282)
3 years, 7 months ago (2017-05-17 13:54:33 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864603003/100001
3 years, 7 months ago (2017-05-18 13:05:51 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458826)
3 years, 7 months ago (2017-05-18 14:29:29 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864603003/100001
3 years, 7 months ago (2017-05-18 14:35:06 UTC) #43
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 18:43:37 UTC) #46
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/868006705aed11538a1402f4db46...

Powered by Google App Engine
This is Rietveld 408576698