Implement and ship PushSubscription.expirationTime

Implement and ship PushSubscription.expirationTime

This property tells developers the time after which the subscription
will be deactivated, if any. Since we don't support refreshing
subscriptions yet, it always returns NULL.

Specification:
https://w3c.github.io/push-api/#dom-pushsubscription-expirationtime

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/xCTqjIDrOm4/discussion

BUG=718837
Review-Url: https://codereview.chromium.org/2864603003
Cr-Commit-Position: refs/heads/master@{#472886}
Committed: https://chromium.googlesource.com/chromium/src/+/868006705aed11538a1402f4db46953e2cfe2a5a

[Peter Beverloo, 2017-05-05 13:05:25]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 13:05:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-05-05 13:13:47]

Description was changed from

==========
Implement and ship PushSubscription.expirationTime

This property tells developers the time after which the subscription
will be deactivated, if any. Since we don't support refreshing
subscriptions yet, it always returns NULL.

Specification:
https://w3c.github.io/push-api/#dom-pushsubscription-expirationtime

Intent to Implement and Ship:
PENDING

BUG=718837
==========

to

==========
Implement and ship PushSubscription.expirationTime

This property tells developers the time after which the subscription
will be deactivated, if any. Since we don't support refreshing
subscriptions yet, it always returns NULL.

Specification:
https://w3c.github.io/push-api/#dom-pushsubscription-expirationtime

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/xCTqjIDrOm4/discus...

BUG=718837
==========

[Peter Beverloo, 2017-05-05 13:14:19]

peter@chromium.org changed reviewers:
+ jochen@chromium.org, johnme@chromium.org

[Peter Beverloo, 2017-05-05 13:14:20]

+johnme for push
+jochen for webexposed tests

[jochen (gone - plz use gerrit), 2017-05-05 14:35:42]

https://codereview.chromium.org/2864603003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp
(right):

https://codereview.chromium.org/2864603003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp:49:
DOMTimeStamp PushSubscription::expirationTime(bool& is_null) const {
why not bool*?

[Peter Beverloo, 2017-05-05 14:42:55]

https://codereview.chromium.org/2864603003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp
(right):

https://codereview.chromium.org/2864603003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp:49:
DOMTimeStamp PushSubscription::expirationTime(bool& is_null) const {
On 2017/05/05 14:35:42, jochen wrote:
> why not bool*?

WebKit was very much about references as opposed to pointers, so this is how I
implemented nullable values many many years ago. That seems to have survived the
various rewrites our bindings code has gone through over the years :).

[commit-bot: I haz the power, 2017-05-05 14:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 14:53:46]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Peter Beverloo, 2017-05-05 15:33:58]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 15:34:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 17:48:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 17:48:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jochen (gone - plz use gerrit), 2017-05-08 06:18:11]

ok, fair enough

still waiting for the blink-dev thread to be resolved

[Peter Beverloo, 2017-05-08 11:45:43]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 11:45:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[johnme, 2017-05-08 12:06:10]

lgtm from push messaging POV

https://codereview.chromium.org/2864603003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/push_messaging/PushSubscription.h
(right):

https://codereview.chromium.org/2864603003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/push_messaging/PushSubscription.h:41:
DOMTimeStamp expirationTime(bool& is_null) const;
Nit: out_is_null seems a little more explicit (and matches the example in
https://docs.google.com/document/d/1ZQLiQKw9hCOyDDhDS4JhckhuiJmLqSbw9FLfySMyx...).

[Peter Beverloo, 2017-05-08 14:42:34]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[Peter Beverloo, 2017-05-08 14:42:37]

https://codereview.chromium.org/2864603003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/push_messaging/PushSubscription.h
(right):

https://codereview.chromium.org/2864603003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/push_messaging/PushSubscription.h:41:
DOMTimeStamp expirationTime(bool& is_null) const;
On 2017/05/08 12:06:10, johnme wrote:
> Nit: out_is_null seems a little more explicit (and matches the example in
>
https://docs.google.com/document/d/1ZQLiQKw9hCOyDDhDS4JhckhuiJmLqSbw9FLfySMyx...).

Done.

[commit-bot: I haz the power, 2017-05-08 14:42:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 14:59:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 14:59:21]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Peter Beverloo, 2017-05-16 14:20:59]

jochen@ - PTAL at webexposed OWNERS here too, this passed as well.

I'll rebase on top of https://codereview.chromium.org/2863443002/

[jochen (gone - plz use gerrit), 2017-05-16 14:25:22]

lgtm

[Peter Beverloo, 2017-05-16 14:41:16]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 14:41:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 15:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 15:48:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Peter Beverloo, 2017-05-16 16:41:36]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 16:42:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 18:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:26:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Beverloo, 2017-05-17 12:13:34]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2017-05-17 12:13:35]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2864603003/#ps100001
(title: "mac results")

[commit-bot: I haz the power, 2017-05-17 12:13:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 13:54:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 13:54:33]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Beverloo, 2017-05-18 13:05:09]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-05-18 13:05:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 14:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 14:29:29]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Beverloo, 2017-05-18 14:34:26]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-05-18 14:35:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 18:43:20]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495118066209170,
"parent_rev": "6548bcbdb7254440df8aab0fa8d9bc1dc179364e", "commit_rev":
"868006705aed11538a1402f4db46953e2cfe2a5a"}

[commit-bot: I haz the power, 2017-05-18 18:43:35]

Description was changed from

==========
Implement and ship PushSubscription.expirationTime

This property tells developers the time after which the subscription
will be deactivated, if any. Since we don't support refreshing
subscriptions yet, it always returns NULL.

Specification:
https://w3c.github.io/push-api/#dom-pushsubscription-expirationtime

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/xCTqjIDrOm4/discus...

BUG=718837
==========

to

==========
Implement and ship PushSubscription.expirationTime

This property tells developers the time after which the subscription
will be deactivated, if any. Since we don't support refreshing
subscriptions yet, it always returns NULL.

Specification:
https://w3c.github.io/push-api/#dom-pushsubscription-expirationtime

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/xCTqjIDrOm4/discus...

BUG=718837

Review-Url: https://codereview.chromium.org/2864603003
Cr-Commit-Position: refs/heads/master@{#472886}
Committed:
https://chromium.googlesource.com/chromium/src/+/868006705aed11538a1402f4db46...
==========

[commit-bot: I haz the power, 2017-05-18 18:43:37]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/868006705aed11538a1402f4db46...