Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.cc

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_metrics_util.cc
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.cc b/components/password_manager/core/browser/password_manager_metrics_util.cc
index ebe75e7ab9100d8c082f2e87421974843a2eb7c2..164f55d6071d7b69e8fb33f91a0ffcd1156f1048 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.cc
+++ b/components/password_manager/core/browser/password_manager_metrics_util.cc
@@ -132,14 +132,18 @@ void LogAccountChooserUsability(AccountChooserUsabilityMetric usability,
}
void LogCredentialManagerGetResult(CredentialManagerGetResult result,
- CredentialManagerGetMediation status) {
- switch (status) {
- case CREDENTIAL_MANAGER_GET_UNMEDIATED:
- UMA_HISTOGRAM_ENUMERATION("PasswordManager.GetUnmediated", result,
+ CredentialMediationRequirement mediation) {
+ switch (mediation) {
+ case CredentialMediationRequirement::kSilent:
+ UMA_HISTOGRAM_ENUMERATION("PasswordManager.MediationSilent", result,
CREDENTIAL_MANAGER_GET_COUNT);
break;
- case CREDENTIAL_MANAGER_GET_MEDIATED:
- UMA_HISTOGRAM_ENUMERATION("PasswordManager.GetMediated", result,
+ case CredentialMediationRequirement::kOptional:
+ UMA_HISTOGRAM_ENUMERATION("PasswordManager.MediationOptional", result,
+ CREDENTIAL_MANAGER_GET_COUNT);
+ break;
+ case CredentialMediationRequirement::kRequired:
+ UMA_HISTOGRAM_ENUMERATION("PasswordManager.MediationRequired", result,
CREDENTIAL_MANAGER_GET_COUNT);
break;
}

Powered by Google App Engine
This is Rietveld 408576698