Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Side by Side Diff: components/password_manager/core/browser/password_manager_metrics_util.cc

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/password_manager_metrics_util .h" 5 #include "components/password_manager/core/browser/password_manager_metrics_util .h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/metrics/user_metrics.h" 9 #include "base/metrics/user_metrics.h"
10 #include "base/numerics/safe_conversions.h" 10 #include "base/numerics/safe_conversions.h"
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 int count_accounts) { 125 int count_accounts) {
126 UMA_HISTOGRAM_ENUMERATION("PasswordManager.AccountChooserDialogUsability", 126 UMA_HISTOGRAM_ENUMERATION("PasswordManager.AccountChooserDialogUsability",
127 usability, ACCOUNT_CHOOSER_USABILITY_COUNT); 127 usability, ACCOUNT_CHOOSER_USABILITY_COUNT);
128 UMA_HISTOGRAM_COUNTS_100("PasswordManager.AccountChooserDialogEmptyAvatars", 128 UMA_HISTOGRAM_COUNTS_100("PasswordManager.AccountChooserDialogEmptyAvatars",
129 count_empty_icons); 129 count_empty_icons);
130 UMA_HISTOGRAM_COUNTS_100("PasswordManager.AccountChooserDialogAccounts", 130 UMA_HISTOGRAM_COUNTS_100("PasswordManager.AccountChooserDialogAccounts",
131 count_accounts); 131 count_accounts);
132 } 132 }
133 133
134 void LogCredentialManagerGetResult(CredentialManagerGetResult result, 134 void LogCredentialManagerGetResult(CredentialManagerGetResult result,
135 CredentialManagerGetMediation status) { 135 CredentialMediationRequirement mediation) {
136 switch (status) { 136 switch (mediation) {
137 case CREDENTIAL_MANAGER_GET_UNMEDIATED: 137 case CredentialMediationRequirement::kSilent:
138 UMA_HISTOGRAM_ENUMERATION("PasswordManager.GetUnmediated", result, 138 UMA_HISTOGRAM_ENUMERATION("PasswordManager.MediationSilent", result,
139 CREDENTIAL_MANAGER_GET_COUNT); 139 CREDENTIAL_MANAGER_GET_COUNT);
140 break; 140 break;
141 case CREDENTIAL_MANAGER_GET_MEDIATED: 141 case CredentialMediationRequirement::kOptional:
142 UMA_HISTOGRAM_ENUMERATION("PasswordManager.GetMediated", result, 142 UMA_HISTOGRAM_ENUMERATION("PasswordManager.MediationOptional", result,
143 CREDENTIAL_MANAGER_GET_COUNT);
144 break;
145 case CredentialMediationRequirement::kRequired:
146 UMA_HISTOGRAM_ENUMERATION("PasswordManager.MediationRequired", result,
143 CREDENTIAL_MANAGER_GET_COUNT); 147 CREDENTIAL_MANAGER_GET_COUNT);
144 break; 148 break;
145 } 149 }
146 } 150 }
147 151
148 void LogPasswordReuse(int password_length, 152 void LogPasswordReuse(int password_length,
149 int saved_passwords, 153 int saved_passwords,
150 int number_matches, 154 int number_matches,
151 bool password_field_detected) { 155 bool password_field_detected) {
152 UMA_HISTOGRAM_COUNTS_100("PasswordManager.PasswordReuse.PasswordLength", 156 UMA_HISTOGRAM_COUNTS_100("PasswordManager.PasswordReuse.PasswordLength",
(...skipping 25 matching lines...) Expand all
178 autofill::PasswordForm::SubmissionIndicatorEvent event) { 182 autofill::PasswordForm::SubmissionIndicatorEvent event) {
179 UMA_HISTOGRAM_ENUMERATION( 183 UMA_HISTOGRAM_ENUMERATION(
180 "PasswordManager.SuccessfulSubmissionIndicatorEvent", event, 184 "PasswordManager.SuccessfulSubmissionIndicatorEvent", event,
181 autofill::PasswordForm::SubmissionIndicatorEvent:: 185 autofill::PasswordForm::SubmissionIndicatorEvent::
182 SUBMISSION_INDICATOR_EVENT_COUNT); 186 SUBMISSION_INDICATOR_EVENT_COUNT);
183 } 187 }
184 188
185 } // namespace metrics_util 189 } // namespace metrics_util
186 190
187 } // namespace password_manager 191 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698