Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 2864493003: Deprecate CredentialRequestOptions.unmediated in favor mediation enum (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_metrics_util.h
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
index 20ba9cfcb4d85b6c431532e2d79864a7f4358bd0..566b075fda361ee97c4dd7402572eb4fae82123c 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.h
+++ b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -10,6 +10,7 @@
#include <string>
#include "components/autofill/core/common/password_form.h"
+#include "components/password_manager/core/common/credential_manager_types.h"
namespace password_manager {
@@ -170,11 +171,6 @@ enum CredentialManagerGetResult {
CREDENTIAL_MANAGER_GET_COUNT
};
-enum CredentialManagerGetMediation {
- CREDENTIAL_MANAGER_GET_MEDIATED,
- CREDENTIAL_MANAGER_GET_UNMEDIATED
-};
-
// Metrics: "PasswordManager.HttpPasswordMigrationMode"
enum HttpPasswordMigrationMode {
HTTP_PASSWORD_MIGRATION_MODE_MOVE,
@@ -247,10 +243,9 @@ void LogAccountChooserUsability(AccountChooserUsabilityMetric usability,
int count_empty_icons,
int count_accounts);
-// Log the result of navigator.credentials.get. |status| specifies the
-// "unmediated" parameter of the API method.
+// Log the result of navigator.credentials.get.
void LogCredentialManagerGetResult(CredentialManagerGetResult result,
- CredentialManagerGetMediation status);
+ CredentialMediationRequirement mediation);
// Log the password reuse.
void LogPasswordReuse(int password_length,

Powered by Google App Engine
This is Rietveld 408576698