Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2864473002:
Declare TaskTraits for blocking USB tasks in a constexpr (Closed)
|
Created:
3 years, 7 months ago by Reilly Grant (use Gerrit) Modified:
3 years, 7 months ago Reviewers:
Jeffrey Yasskin CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDeclare TaskTraits for blocking USB tasks in a constexpr
This is the cleanup I suggested in https://crrev.com/2855233002/#msg5
to declare the appropriate task traits for posting blocking tasks in a
single place so that there is consistency (and reduced duplication)
across //device/usb.
BUG=None
Review-Url: https://codereview.chromium.org/2864473002
Cr-Commit-Position: refs/heads/master@{#473108}
Committed: https://chromium.googlesource.com/chromium/src/+/375fc7a1d4e279c675ce23f239604f8aa80fef53
Patch Set 1 #Patch Set 2 : Use constexpr when declaring storage #Patch Set 3 : Rebased #
Messages
Total messages: 32 (19 generated)
The CQ bit was checked by reillyg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by reillyg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
reillyg@chromium.org changed reviewers: + jyasskin@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Ping.
Ping.
LGTM. Sorry for missing this.
The CQ bit was checked by reillyg@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Rebased
The CQ bit was checked by reillyg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jyasskin@chromium.org Link to the patchset: https://codereview.chromium.org/2864473002/#ps40001 (title: "Rebased")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by reillyg@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by reillyg@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495172998640520,
"parent_rev": "71170ccede8e41584e8e5cf20e1c010f17855272", "commit_rev":
"375fc7a1d4e279c675ce23f239604f8aa80fef53"}
Message was sent while issue was closed.
Description was changed from ========== Declare TaskTraits for blocking USB tasks in a constexpr This is the cleanup I suggested in https://crrev.com/2855233002/#msg5 to declare the appropriate task traits for posting blocking tasks in a single place so that there is consistency (and reduced duplication) across //device/usb. BUG=None ========== to ========== Declare TaskTraits for blocking USB tasks in a constexpr This is the cleanup I suggested in https://crrev.com/2855233002/#msg5 to declare the appropriate task traits for posting blocking tasks in a single place so that there is consistency (and reduced duplication) across //device/usb. BUG=None Review-Url: https://codereview.chromium.org/2864473002 Cr-Commit-Position: refs/heads/master@{#473108} Committed: https://chromium.googlesource.com/chromium/src/+/375fc7a1d4e279c675ce23f23960... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/375fc7a1d4e279c675ce23f23960... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
