Fix 'VirtualKeyboard.InitLatency.FirstLoad' metrics to be recorded for any keyboards.

Fix 'VirtualKeyboard.InitLatency.FirstLoad' metric to be recorded for any keyboards.

This metric was recorded when
chrome.virtualKeyboardPrivate.keyboardLoaded API, but some keyboards
don't call this API after loading is finished.
In order to record this metric for any keyboard, this CL changes to
call MarkKeyboardLoadFinished() after showing animation is finished.

TEST=Confirm that the metrics is recorded in chrome://histograms.
BUG=708362, 705926
Review-Url: https://codereview.chromium.org/2864413003
Cr-Commit-Position: refs/heads/master@{#471978}
Committed: https://chromium.googlesource.com/chromium/src/+/2f2a04f5e41f313d9170f6263c12f780024093f4

[yhanada, 2017-05-09 07:12:30]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 07:12:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhanada, 2017-05-09 07:31:19]

Description was changed from

==========
Fix 'VirtualKeyboard.InitLatency.FirstLoad' metrics to be recorded for any
keyboards.

This metric was recorded when
chrome.virtualKeyboardPrivate.keyboardLoaded API, but some keyboards
don't call this API after loading is finished.
In order to record this metric for any keyboard, this CL changes to
call MarkKeyboardLoadFinished() after showing animation is finished.

TEST=Confirm that the metrics is recorded in chrome://histograms.
BUG=708362, 705926
==========

to

==========
Fix 'VirtualKeyboard.InitLatency.FirstLoad' metric to be recorded for any
keyboards.

This metric was recorded when
chrome.virtualKeyboardPrivate.keyboardLoaded API, but some keyboards
don't call this API after loading is finished.
In order to record this metric for any keyboard, this CL changes to
call MarkKeyboardLoadFinished() after showing animation is finished.

TEST=Confirm that the metrics is recorded in chrome://histograms.
BUG=708362, 705926
==========

[commit-bot: I haz the power, 2017-05-09 09:43:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 09:43:14]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-05-09 10:10:18]

yhanada@chromium.org changed reviewers:
+ sadrul@chromium.org

[yhanada, 2017-05-09 10:10:19]

PTAL. Thanks!

[sadrul, 2017-05-10 01:07:17]

On 2017/05/09 10:10:19, yhanada wrote:
> PTAL. Thanks!

Should
https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/virtual_ke...
be removed? Because otherwise, we would be getting the timing data at different
times for different imes, right?

The change itself lgtm

[yhanada, 2017-05-10 01:26:50]

yhanada@chromium.org changed reviewers:
+ bshe@chromium.org

[yhanada, 2017-05-10 01:27:29]

On 2017/05/10 01:07:17, sadrul wrote:
> On 2017/05/09 10:10:19, yhanada wrote:
> > PTAL. Thanks!
> 
> Should
>
https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/virtual_ke...
> be removed? Because otherwise, we would be getting the timing data at
different
> times for different imes, right?
> 
> The change itself lgtm

Yes. I removed it.

bshe@: PTAL.

[yhanada, 2017-05-11 01:42:11]

yhanada@chromium.org changed reviewers:
+ kevers@chromium.org

[yhanada, 2017-05-11 01:42:11]

kevers@: Could you review this change because bshe@ is OOO this week?

[yhanada, 2017-05-15 05:27:44]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 05:27:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 06:59:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 06:59:06]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-05-15 07:54:17]

yhanada@chromium.org changed reviewers:
+ sky@chromium.org

[yhanada, 2017-05-15 07:54:17]

sky@: Could you take a look at the change in chrome_virtual_keyboard_delegate.cc
as an OWNER? All owners of c/b/extensions/api/virtual_keyboard_private are OOO
all this week.

[sky, 2017-05-15 15:43:42]

LGTM

[yhanada, 2017-05-16 01:32:00]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2017-05-16 01:32:01]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2864413003/#ps40001
(title: "rebase")

[yhanada, 2017-05-16 01:32:25]

Thank you all for reviewing!

[commit-bot: I haz the power, 2017-05-16 01:34:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:47:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494898320755130,
"parent_rev": "56fd91872a4109611d4c1142243b349e430b61a2", "commit_rev":
"2f2a04f5e41f313d9170f6263c12f780024093f4"}

[commit-bot: I haz the power, 2017-05-16 01:48:09]

Description was changed from

==========
Fix 'VirtualKeyboard.InitLatency.FirstLoad' metric to be recorded for any
keyboards.

This metric was recorded when
chrome.virtualKeyboardPrivate.keyboardLoaded API, but some keyboards
don't call this API after loading is finished.
In order to record this metric for any keyboard, this CL changes to
call MarkKeyboardLoadFinished() after showing animation is finished.

TEST=Confirm that the metrics is recorded in chrome://histograms.
BUG=708362, 705926
==========

to

==========
Fix 'VirtualKeyboard.InitLatency.FirstLoad' metric to be recorded for any
keyboards.

This metric was recorded when
chrome.virtualKeyboardPrivate.keyboardLoaded API, but some keyboards
don't call this API after loading is finished.
In order to record this metric for any keyboard, this CL changes to
call MarkKeyboardLoadFinished() after showing animation is finished.

TEST=Confirm that the metrics is recorded in chrome://histograms.
BUG=708362, 705926

Review-Url: https://codereview.chromium.org/2864413003
Cr-Commit-Position: refs/heads/master@{#471978}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f2a04f5e41f313d9170f6263c12...
==========

[commit-bot: I haz the power, 2017-05-16 01:48:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2f2a04f5e41f313d9170f6263c12...