Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: ui/keyboard/keyboard_util.cc

Issue 2864413003: Fix 'VirtualKeyboard.InitLatency.FirstLoad' metrics to be recorded for any keyboards. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/keyboard/keyboard_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_util.cc
diff --git a/ui/keyboard/keyboard_util.cc b/ui/keyboard/keyboard_util.cc
index c80d9f1a03c553aca883d81510a278f80f2f623c..a9c14ba8b0354f76ea04fbc6001a85dbc1566a48 100644
--- a/ui/keyboard/keyboard_util.cc
+++ b/ui/keyboard/keyboard_util.cc
@@ -369,20 +369,16 @@ bool SendKeyEvent(const std::string type,
}
void MarkKeyboardLoadStarted() {
- if (!g_keyboard_load_time_start.Get().ToInternalValue())
+ if (g_keyboard_load_time_start.Get().is_null())
g_keyboard_load_time_start.Get() = base::Time::Now();
}
void MarkKeyboardLoadFinished() {
// Possible to get a load finished without a start if navigating directly to
// chrome://keyboard.
- if (!g_keyboard_load_time_start.Get().ToInternalValue())
+ if (g_keyboard_load_time_start.Get().is_null())
return;
- // It should not be possible to finish loading the keyboard without starting
- // to load it first.
- DCHECK(g_keyboard_load_time_start.Get().ToInternalValue());
-
static bool logged = false;
if (!logged) {
// Log the delta only once.
« no previous file with comments | « ui/keyboard/keyboard_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698