Remove DartString from constants.

Remove DartString from constants.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/7fa9fc7e2e397a571c0eab68031863044c117e16

[Johnni Winther, 2017-05-08 13:20:00]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-08 22:24:04]

lgtm

https://codereview.chromium.org/2864363002/diff/1/pkg/compiler/lib/src/consta...
File pkg/compiler/lib/src/constants/values.dart (right):

https://codereview.chromium.org/2864363002/diff/1/pkg/compiler/lib/src/consta...
pkg/compiler/lib/src/constants/values.dart:416: String toDartString() =>
primitiveValue;
we could also get rid of the 'toDartString' entirely, and replace the evaluator
logic to say:

`'${primitiveConstantValue.primitiveValue}'` 

wdyt? Mainly that would be to not get confused with the "DartString" type in the
future when we see `toDartString`.

[Johnni Winther, 2017-05-09 08:18:13]

https://codereview.chromium.org/2864363002/diff/1/pkg/compiler/lib/src/consta...
File pkg/compiler/lib/src/constants/values.dart (right):

https://codereview.chromium.org/2864363002/diff/1/pkg/compiler/lib/src/consta...
pkg/compiler/lib/src/constants/values.dart:416: String toDartString() =>
primitiveValue;
On 2017/05/08 22:24:04, Siggi Cherem (dart-lang) wrote:
> we could also get rid of the 'toDartString' entirely, and replace the
evaluator
> logic to say:
> 
> `'${primitiveConstantValue.primitiveValue}'` 
> 
> wdyt? Mainly that would be to not get confused with the "DartString" type in
the
> future when we see `toDartString`.

Done.

[Johnni Winther, 2017-05-09 08:26:49]

Description was changed from

==========
Remove DartString from constants.
==========

to

==========
Remove DartString from constants.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7fa9fc7e2e397a571c0eab68031863044c117e16
==========

[Johnni Winther, 2017-05-09 08:26:50]

Committed patchset #2 (id:20001) manually as
7fa9fc7e2e397a571c0eab68031863044c117e16 (presubmit successful).