Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 2864363002: Remove DartString from constants. (Closed)
Patch Set: Remove toDartString Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/namer.dart
diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart
index 01ce064a1ff3915a5e2194aa090bd3cc947a64e5..92f5b1427a05b0d5b92cd87cb667b2daf681be4c 100644
--- a/pkg/compiler/lib/src/js_backend/namer.dart
+++ b/pkg/compiler/lib/src/js_backend/namer.dart
@@ -1810,7 +1810,7 @@ class ConstantNamingVisitor implements ConstantValueVisitor {
@override
void visitString(StringConstantValue constant, [_]) {
// No `addRoot` since string constants are always inlined.
- addIdentifier(constant.primitiveValue.slowToString());
+ addIdentifier(constant.primitiveValue);
}
@override
@@ -1980,7 +1980,7 @@ class ConstantCanonicalHasher implements ConstantValueVisitor<int, Null> {
@override
int visitString(StringConstantValue constant, [_]) {
- return _hashString(2, constant.primitiveValue.slowToString());
+ return _hashString(2, constant.primitiveValue);
}
@override
« no previous file with comments | « pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart ('k') | pkg/compiler/lib/src/js_emitter/constant_ordering.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698