pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart - Issue 2864363002: Remove DartString from constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart

Issue 2864363002: Remove DartString from constants. (Closed)

Patch Set: Remove toDartString Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart

diff --git a/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart b/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart

index 43fae68bd5b0a4f3c9bab4db03c67a0d56d75178..5ba025f1a002f35b880efe953011b89de88b6278 100644

--- a/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart

+++ b/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart

@@ -146,7 +146,7 @@ class LookupMapAnalysis {

// when we introduce the next version.

Version version;

try {

- version = new Version.parse(value.primitiveValue.slowToString());

+ version = new Version.parse(value.primitiveValue);

} catch (e) {}

if (version == null || !_validLookupMapVersionConstraint.allows(version)) {