Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2863993003: Refactor windows dependency out of UpdaterState class. (Closed)

Created:
3 years, 7 months ago by Sorin Jianu
Modified:
3 years, 7 months ago
Reviewers:
waffles, Boris Vidolov
CC:
chromium-reviews, Boris Vidolov
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor windows dependency out of UpdaterState class; BUG=718916 Review-Url: https://codereview.chromium.org/2863993003 Cr-Commit-Position: refs/heads/master@{#469689} Committed: https://chromium.googlesource.com/chromium/src/+/a0a5a62f736a57278092edbf232f61d68394b02e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M components/update_client/updater_state.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/update_client/updater_state_win.cc View 2 chunks +15 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Sorin Jianu
PTAL! TY!
3 years, 7 months ago (2017-05-05 16:04:44 UTC) #5
Boris Vidolov
lgtm
3 years, 7 months ago (2017-05-05 16:49:59 UTC) #7
waffles
lgtm
3 years, 7 months ago (2017-05-05 16:51:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863993003/1
3 years, 7 months ago (2017-05-05 16:55:07 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 17:08:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0a5a62f736a57278092edbf232f...

Powered by Google App Engine
This is Rietveld 408576698