Refactor windows dependency out of UpdaterState class.

components/update_client/updater_state_win.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/update_client/updater_state.h"
 
 #include <string>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 24 matching lines @@
 
 // Google Update registry settings.
 const wchar_t kRegPathGoogleUpdate[] = L"Software\\Google\\Update";
 const wchar_t kRegPathClientsGoogleUpdate[] =
     L"Software\\Google\\Update\\Clients\\"
     L"{430FD4D0-B729-4F61-AA34-91526481799D}";
 const wchar_t kRegValueGoogleUpdatePv[] = L"pv";
 const wchar_t kRegValueLastStartedAU[] = L"LastStartedAU";
 const wchar_t kRegValueLastChecked[] = L"LastChecked";
 
+base::Time GetUpdaterTimeValue(bool is_machine, const wchar_t* value_name) {
+  const HKEY root_key = is_machine ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
+  base::win::RegKey update_key;
+
+  if (update_key.Open(root_key, kRegPathGoogleUpdate,
+                      KEY_QUERY_VALUE | KEY_WOW64_32KEY) == ERROR_SUCCESS) {
+    DWORD value(0);
+    if (update_key.ReadValueDW(value_name, &value) == ERROR_SUCCESS) {
+      return base::Time::FromTimeT(value);
+    }
+  }
+
+  return base::Time();
+}
+
 }  // namespace
 
 std::string UpdaterState::GetUpdaterName() {
   return std::string("Omaha");
 }
 
 base::Version UpdaterState::GetUpdaterVersion(bool is_machine) {
   const HKEY root_key = is_machine ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
   base::string16 version;
   base::win::RegKey key;
 
   if (key.Open(root_key, kRegPathClientsGoogleUpdate,
                KEY_QUERY_VALUE | KEY_WOW64_32KEY) == ERROR_SUCCESS &&
       key.ReadValue(kRegValueGoogleUpdatePv, &version) == ERROR_SUCCESS) {
     return base::Version(base::UTF16ToUTF8(version));
   }
 
   return base::Version();
 }
 
 base::Time UpdaterState::GetUpdaterLastStartedAU(bool is_machine) {
   return GetUpdaterTimeValue(is_machine, kRegValueLastStartedAU);
 }
 
 base::Time UpdaterState::GetUpdaterLastChecked(bool is_machine) {
   return GetUpdaterTimeValue(is_machine, kRegValueLastChecked);
 }
 
-base::Time UpdaterState::GetUpdaterTimeValue(bool is_machine,
-                                             const wchar_t* value_name) {
-  const HKEY root_key = is_machine ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
-  base::win::RegKey update_key;
-
-  if (update_key.Open(root_key, kRegPathGoogleUpdate,
-                      KEY_QUERY_VALUE | KEY_WOW64_32KEY) == ERROR_SUCCESS) {
-    DWORD value(0);
-    if (update_key.ReadValueDW(value_name, &value) == ERROR_SUCCESS) {
-      return base::Time::FromTimeT(value);
-    }
-  }
-
-  return base::Time();
-}
-
 bool UpdaterState::IsAutoupdateCheckEnabled() {
   // Check the auto-update check period override. If it is 0 or exceeds the
   // maximum timeout, then for all intents and purposes auto updates are
   // disabled.
   base::win::RegKey policy_key;
   DWORD value = 0;
   if (policy_key.Open(HKEY_LOCAL_MACHINE, kGoogleUpdatePoliciesKey,
                       KEY_QUERY_VALUE) == ERROR_SUCCESS &&
       policy_key.ReadValueDW(kCheckPeriodOverrideMinutes, &value) ==
           ERROR_SUCCESS &&
@@ skipping 32 matching lines @@
   }
 
   return -1;
 }
 
 bool UpdaterState::IsEnterpriseManaged() {
   return base::win::IsEnterpriseManaged();
 }
 
 }  // namespace update_client