Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 2863943002: [heap] Memory reducer calls GC with kGCCallbackFlagCollectAllExternalMemory flag. (Closed)

Created:
3 years, 7 months ago by Hannes Payer (out of office)
Modified:
3 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Memory reducer calls GC with kGCCallbackFlagCollectAllExternalMemory flag. BUG=chromium:718484 Review-Url: https://codereview.chromium.org/2863943002 Cr-Commit-Position: refs/heads/master@{#45128} Committed: https://chromium.googlesource.com/v8/v8/+/8833af23e9788c725b0887446915e4820383a385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/heap/heap.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (10 generated)
ulan
lgtm
3 years, 7 months ago (2017-05-05 09:46:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863943002/1
3 years, 7 months ago (2017-05-05 11:21:51 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 11:24:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8833af23e9788c725b0887446915e482038...

Powered by Google App Engine
This is Rietveld 408576698