Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: src/heap/heap.cc

Issue 2863943002: [heap] Memory reducer calls GC with kGCCallbackFlagCollectAllExternalMemory flag. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.h ('k') | src/heap/memory-reducer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index 0c33fcee034923068acafc538440a19de40cfa3c..65429a4b1090f6c22c3604ea7cf8ad6ef9779b4f 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -1115,10 +1115,12 @@ void Heap::StartIncrementalMarkingIfAllocationLimitIsReached(
}
}
-void Heap::StartIdleIncrementalMarking(GarbageCollectionReason gc_reason) {
+void Heap::StartIdleIncrementalMarking(
+ GarbageCollectionReason gc_reason,
+ const GCCallbackFlags gc_callback_flags) {
gc_idle_time_handler_->ResetNoProgressCounter();
StartIncrementalMarking(kReduceMemoryFootprintMask, gc_reason,
- kNoGCCallbackFlags);
+ gc_callback_flags);
}
@@ -4232,7 +4234,7 @@ void Heap::FinalizeIncrementalMarkingIfComplete(
(mark_compact_collector()->marking_deque()->IsEmpty() &&
local_embedder_heap_tracer()
->ShouldFinalizeIncrementalMarking())) {
- CollectAllGarbage(current_gc_flags_, gc_reason);
+ CollectAllGarbage(current_gc_flags_, gc_reason, current_gc_callback_flags_);
}
}
« no previous file with comments | « src/heap/heap.h ('k') | src/heap/memory-reducer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698