Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2858343003: [heap] Reland Use atomic marking operations in incremental marking if (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland Use atomic marking operations in incremental marking if concurrent marking is enabled. This patch adds kAtomicity flag to IncrementalMarking that is set depending on the concurrent marking compile time flag. BUG=chromium:694255 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.chromium.org/2858343003 Cr-Commit-Position: refs/heads/master@{#45138} Committed: https://chromium.googlesource.com/v8/v8/+/b1d96fa1d410b2b7cfdff6131517dbf5cbfadc20

Patch Set 1 #

Patch Set 2 : ifdef -> if #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -36 lines) Patch
M src/heap/incremental-marking.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 14 chunks +42 lines, -36 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
ulan
Relanding without any changes from the original CL because the CL was revert due to ...
3 years, 7 months ago (2017-05-05 09:35:10 UTC) #2
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-05 09:39:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858343003/20001
3 years, 7 months ago (2017-05-05 11:06:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858343003/60001
3 years, 7 months ago (2017-05-05 13:15:05 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 13:59:41 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/b1d96fa1d410b2b7cfdff6131517dbf5cbf...

Powered by Google App Engine
This is Rietveld 408576698