Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: third_party/WebKit/Source/core/frame/WebLocalFrameBase.h

Issue 2863913002: Change AudioOutputDeviceClientImpl to use WebLocalFrameBase and move to modules. (Closed)
Patch Set: Use chrome client to create instances of WebLocalFrameBase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
diff --git a/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h b/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
index 4c412122fca9dcd2ada1ddef45cb69df985a39c3..c6f805dd2ee1466e2c42effea8058e95801d60e5 100644
--- a/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
+++ b/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h
@@ -1,14 +1,18 @@
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.#ifndef WebViewBase_h
+// found in the LICENSE file.
#ifndef WebLocalFrameBase_h
#define WebLocalFrameBase_h
+#include "core/CoreExport.h"
+#include "public/platform/WebCommon.h"
#include "public/web/WebLocalFrame.h"
namespace blink {
+class LocalFrame;
+
// WebLocalFrameBase is a temporary class the provides a layer of abstraction
// for WebLocalFrameImpl. Mehtods that are declared public in WebLocalFrameImpl
// that are not overrides from WebLocalFrame will be declared pure virtual in
@@ -18,9 +22,17 @@ namespace blink {
// modules.
// TODO(slangley): Remove this class once WebLocalFrameImpl is in core/.
class WebLocalFrameBase : public WebLocalFrame {
+ public:
+ // Creation Methods.
haraken 2017/05/08 04:33:54 Reword this. As dcheng@ said, this is not creating
+ CORE_EXPORT static WebLocalFrameBase* FromFrame(LocalFrame*);
haraken 2017/05/08 04:25:24 FromFrame => Create ?
+ CORE_EXPORT static WebLocalFrameBase* FromFrame(LocalFrame&);
+
+ virtual WebFrameClient* Client() const = 0;
+
protected:
explicit WebLocalFrameBase(WebTreeScopeType scope) : WebLocalFrame(scope) {}
};
-}
+
+} // namespace blink
#endif // WebLocalFrameBase_h

Powered by Google App Engine
This is Rietveld 408576698