Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2863913002: Change AudioOutputDeviceClientImpl to use WebLocalFrameBase and move to modules. (Closed)
Patch Set: Use chrome client to create instances of WebLocalFrameBase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index 6ec80ab3f12c85853bea5b8d605d67e5a5433a5b..2fb9ad1108d3d90c7a7bc5788e82b06f2a54a768 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -57,6 +57,7 @@
#include "core/page/PopupOpeningObserver.h"
#include "modules/accessibility/AXObject.h"
#include "modules/audio_output_devices/AudioOutputDeviceClient.h"
+#include "modules/audio_output_devices/AudioOutputDeviceClientImpl.h"
#include "modules/installedapp/InstalledAppController.h"
#include "modules/mediastream/UserMediaController.h"
#include "modules/navigatorcontentutils/NavigatorContentUtils.h"
@@ -107,7 +108,6 @@
#include "public/web/WebUserGestureToken.h"
#include "public/web/WebViewClient.h"
#include "public/web/WebWindowFeatures.h"
-#include "web/AudioOutputDeviceClientImpl.h"
#include "web/ColorChooserPopupUIController.h"
#include "web/ColorChooserUIController.h"
#include "web/DateTimeChooserImpl.h"
@@ -1247,4 +1247,9 @@ void ChromeClientImpl::InstallSupplements(LocalFrame& frame) {
InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher());
}
+WebLocalFrameBase* ChromeClientImpl::CreateWebLocalFrameBase(
haraken 2017/05/08 04:25:24 Maybe should we call this CreateWebLocalFrameImpl?
dcheng 2017/05/08 04:29:44 This isn't actually creating any objects though, i
haraken 2017/05/08 04:33:54 Ah, right. FromFrame() sounds nice.
+ LocalFrame* frame) {
+ return WebLocalFrameImpl::FromFrame(frame);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698