Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. | 1 // Copyright 2017 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file.#ifndef WebViewBase_h | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef WebLocalFrameBase_h | 5 #ifndef WebLocalFrameBase_h |
| 6 #define WebLocalFrameBase_h | 6 #define WebLocalFrameBase_h |
| 7 | 7 |
| 8 #include "core/CoreExport.h" | |
| 9 #include "public/platform/WebCommon.h" | |
| 8 #include "public/web/WebLocalFrame.h" | 10 #include "public/web/WebLocalFrame.h" |
| 9 | 11 |
| 10 namespace blink { | 12 namespace blink { |
| 11 | 13 |
| 14 class LocalFrame; | |
| 15 | |
| 12 // WebLocalFrameBase is a temporary class the provides a layer of abstraction | 16 // WebLocalFrameBase is a temporary class the provides a layer of abstraction |
| 13 // for WebLocalFrameImpl. Mehtods that are declared public in WebLocalFrameImpl | 17 // for WebLocalFrameImpl. Mehtods that are declared public in WebLocalFrameImpl |
| 14 // that are not overrides from WebLocalFrame will be declared pure virtual in | 18 // that are not overrides from WebLocalFrame will be declared pure virtual in |
| 15 // WebLocalFrameBase. Classes that then have a dependency on WebLocalFrameImpl | 19 // WebLocalFrameBase. Classes that then have a dependency on WebLocalFrameImpl |
| 16 // will then take a dependency on WebLocalFrameBase instead, so we can remove | 20 // will then take a dependency on WebLocalFrameBase instead, so we can remove |
| 17 // cyclic dependencies in web/ and move classes from web/ into core/ or | 21 // cyclic dependencies in web/ and move classes from web/ into core/ or |
| 18 // modules. | 22 // modules. |
| 19 // TODO(slangley): Remove this class once WebLocalFrameImpl is in core/. | 23 // TODO(slangley): Remove this class once WebLocalFrameImpl is in core/. |
| 20 class WebLocalFrameBase : public WebLocalFrame { | 24 class WebLocalFrameBase : public WebLocalFrame { |
| 25 public: | |
| 26 // Creation Methods. | |
|
haraken
2017/05/08 04:33:54
Reword this. As dcheng@ said, this is not creating
| |
| 27 CORE_EXPORT static WebLocalFrameBase* FromFrame(LocalFrame*); | |
|
haraken
2017/05/08 04:25:24
FromFrame => Create ?
| |
| 28 CORE_EXPORT static WebLocalFrameBase* FromFrame(LocalFrame&); | |
| 29 | |
| 30 virtual WebFrameClient* Client() const = 0; | |
| 31 | |
| 21 protected: | 32 protected: |
| 22 explicit WebLocalFrameBase(WebTreeScopeType scope) : WebLocalFrame(scope) {} | 33 explicit WebLocalFrameBase(WebTreeScopeType scope) : WebLocalFrame(scope) {} |
| 23 }; | 34 }; |
| 24 } | 35 |
| 36 } // namespace blink | |
| 25 | 37 |
| 26 #endif // WebLocalFrameBase_h | 38 #endif // WebLocalFrameBase_h |
| OLD | NEW |