Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2863843002: [Merge to M59] Gtk3: Add background class to tooltips (Closed)

Created:
3 years, 7 months ago by Tom Anderson
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to M59] Gtk3: Add background class to tooltips > This CL fixes the tooltip background color on the non-Dark variant of > Adwaita which requires tooltips have the "background" class [1]. > > Additionally, this CL avoids creating a selector with a GtkWindow > parent class on Gtk 3.20. This avoids tinting the tooltip with the > window background color if tooltips have transparency (FYI: Chrome > tooltips are opaque, so the alpha will be ignored). > > [1] https://github.com/GNOME/gtk/blob/ee3994f715a2f53519f1478d2f08c6548471a8ae/gtk/theme/Adwaita/gtk-contained.css#L4387 > > BUG=716599 > R=erg@chromium.org > > Review-Url: https://codereview.chromium.org/2855063002 > Cr-Commit-Position: refs/heads/master@{#469165} BUG=716599 TBR=erg@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2863843002 Cr-Commit-Position: refs/branch-heads/3071@{#410} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f750c37727efbda389408dc93b81c8861cacae5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M chrome/browser/ui/libgtkui/gtk_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863843002/1
3 years, 7 months ago (2017-05-04 23:48:24 UTC) #2
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 23:49:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f750c37727efbda389408dc93b81...

Powered by Google App Engine
This is Rietveld 408576698