Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2855063002: Gtk3: Add background class to tooltips (Closed)

Created:
3 years, 7 months ago by Tom (Use chromium acct)
Modified:
3 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Add background class to tooltips This CL fixes the tooltip background color on the non-Dark variant of Adwaita which requires tooltips have the "background" class [1]. Additionally, this CL avoids creating a selector with a GtkWindow parent class on Gtk 3.20. This avoids tinting the tooltip with the window background color if tooltips have transparency (FYI: Chrome tooltips are opaque, so the alpha will be ignored). [1] https://github.com/GNOME/gtk/blob/ee3994f715a2f53519f1478d2f08c6548471a8ae/gtk/theme/Adwaita/gtk-contained.css#L4387 BUG=716599 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2855063002 Cr-Commit-Position: refs/heads/master@{#469165} Committed: https://chromium.googlesource.com/chromium/src/+/376a670d2f7ec27bedaf8fae558809c0c60c4b49

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M chrome/browser/ui/libgtkui/gtk_util.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 1 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Tom (Use chromium acct)
3 years, 7 months ago (2017-05-03 00:03:07 UTC) #1
Elliot Glaysher
lgtm
3 years, 7 months ago (2017-05-03 17:36:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855063002/20001
3 years, 7 months ago (2017-05-03 22:17:12 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 22:23:18 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/376a670d2f7ec27bedaf8fae5588...

Powered by Google App Engine
This is Rietveld 408576698