Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2863813002: Reland of Don't set cpu architecture field on iOS in UMA logs. (Closed)

Created:
3 years, 7 months ago by Alexei Svitkine (slow)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, rkaplow, l, Olivier, gchatz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Don't set cpu architecture field on iOS in UMA logs. (patchset #1 id:1 of https://codereview.chromium.org/2855943005/ ) Reason for revert: Can be relanded now that we're filling in hardware class on iOS. Original issue's description: > Revert of Don't set cpu architecture field on iOS in UMA logs. (patchset #2 id:20001 of https://codereview.chromium.org/2671433002/ ) > > Reason for revert: > This breaks Chrome iOS dashboards because cpu_architecture is the only field where we have the device model info (e.g. iPhone7,2). > > Original issue's description: > > Don't set cpu architecture field on iOS in UMA logs. > > > > The value we were setting it to before was not correct, so this > > change instead just makes the value not get set on iOS. > > > > BUG=370104 > > > > Review-Url: https://codereview.chromium.org/2671433002 > > Cr-Commit-Position: refs/heads/master@{#447578} > > Committed: https://chromium.googlesource.com/chromium/src/+/a86e8e115054ad167458d0379980db5473cb20de > > TBR=rkaplow@chromium.org,asvitkine@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=370104, 718080 > > Review-Url: https://codereview.chromium.org/2855943005 > Cr-Commit-Position: refs/heads/master@{#469062} > Committed: https://chromium.googlesource.com/chromium/src/+/9f89092a8f533da1537b0a441b1e137b3d3b2728 TBR=pkl@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=370104, 718080 Review-Url: https://codereview.chromium.org/2863813002 Cr-Commit-Position: refs/heads/master@{#469638} Committed: https://chromium.googlesource.com/chromium/src/+/b293236194e22d784a5d77a04ebfad88e33f824e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M components/metrics/metrics_log.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/metrics/metrics_log_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Alexei Svitkine (slow)
Created Reland of Don't set cpu architecture field on iOS in UMA logs.
3 years, 7 months ago (2017-05-04 23:01:41 UTC) #2
pkl (ping after 24h if needed)
LGTM. If this lands on trunk, it will be M60 and I will need to ...
3 years, 7 months ago (2017-05-05 01:58:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863813002/1
3 years, 7 months ago (2017-05-05 13:06:30 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 14:03:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b293236194e22d784a5d77a04ebf...

Powered by Google App Engine
This is Rietveld 408576698