Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2863783002: Reset HoverHighlightView state before re-populating (Closed)

Created:
3 years, 7 months ago by mohsen
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3086
Project:
chromium
Visibility:
Public.

Description

Reset HoverHighlightView state before re-populating When a HoverHighlightView needs to be repopulated, other than removing its children, the pointers it has to its children should be nulled out, too. Otherwise, it would try to reuse them causing crashes. This CL adds a Reset() function to HoverHighlightView that properly resets the state of HoverHighlightView before re-populating it. BUG=718411 TEST=none Review-Url: https://codereview.chromium.org/2865533002 Cr-Commit-Position: refs/heads/master@{#469480} (cherry picked from commit e5f363be8e46b5e650988d7393390940bd25ff67) Review-Url: https://codereview.chromium.org/2863783002 . Cr-Commit-Position: refs/branch-heads/3086@{#5} Cr-Branched-From: 4159f36e93c398b9816b734a14e97220e83fc912-refs/heads/master@{#468266} Committed: https://chromium.googlesource.com/chromium/src/+/5d20b0cede94b6473d61950c4014b125717804b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -19 lines) Patch
M ash/system/network/network_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/network/vpn_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/hover_highlight_view.h View 3 chunks +25 lines, -17 lines 0 comments Download
M ash/system/tray/hover_highlight_view.cc View 7 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mohsen
3 years, 7 months ago (2017-05-04 22:26:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d20b0cede94b6473d61950c4014b125717804b6.

Powered by Google App Engine
This is Rietveld 408576698