Reset HoverHighlightView state before re-populating

Reset HoverHighlightView state before re-populating

When a HoverHighlightView needs to be repopulated, other than removing
its children, the pointers it has to its children should be nulled out,
too. Otherwise, it would try to reuse them causing crashes. This CL adds
a Reset() function to HoverHighlightView that properly resets the state
of HoverHighlightView before re-populating it.

BUG=718411
TEST=none

Review-Url: https://codereview.chromium.org/2865533002
Cr-Commit-Position: refs/heads/master@{#469480}
Committed: https://chromium.googlesource.com/chromium/src/+/e5f363be8e46b5e650988d7393390940bd25ff67

[mohsen, 2017-05-04 20:54:11]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 20:54:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2017-05-04 20:55:03]

mohsen@chromium.org changed reviewers:
+ tdanderson@chromium.org

[mohsen, 2017-05-04 20:55:03]

Please take a look...

[tdanderson, 2017-05-04 21:25:58]

LGTM

[commit-bot: I haz the power, 2017-05-04 21:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 21:38:28]

Dry run: This issue passed the CQ dry run.

[mohsen, 2017-05-04 21:39:01]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2017-05-04 21:39:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 21:44:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493933941259170, "parent_rev":
"2e3e1972ebbfdcbde70ef7c33c98169641e3f335", "commit_rev":
"e5f363be8e46b5e650988d7393390940bd25ff67"}

[commit-bot: I haz the power, 2017-05-04 21:45:24]

Description was changed from

==========
Reset HoverHighlightView state before re-populating

When a HoverHighlightView needs to be repopulated, other than removing
its children, the pointers it has to its children should be nulled out,
too. Otherwise, it would try to reuse them causing crashes. This CL adds
a Reset() function to HoverHighlightView that properly resets the state
of HoverHighlightView before re-populating it.

BUG=718411
TEST=none
==========

to

==========
Reset HoverHighlightView state before re-populating

When a HoverHighlightView needs to be repopulated, other than removing
its children, the pointers it has to its children should be nulled out,
too. Otherwise, it would try to reuse them causing crashes. This CL adds
a Reset() function to HoverHighlightView that properly resets the state
of HoverHighlightView before re-populating it.

BUG=718411
TEST=none

Review-Url: https://codereview.chromium.org/2865533002
Cr-Commit-Position: refs/heads/master@{#469480}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5f363be8e46b5e650988d739339...
==========

[commit-bot: I haz the power, 2017-05-04 21:45:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5f363be8e46b5e650988d739339...