Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2863633003: Reenable WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate. (Closed)

Created:
3 years, 7 months ago by paulmeyer
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate. BUG=710486 TBR=wjmaclean@chromium.org Review-Url: https://codereview.chromium.org/2863633003 Cr-Commit-Position: refs/heads/master@{#469465} Committed: https://chromium.googlesource.com/chromium/src/+/2a3f50f3684ccd28c4eb5160909a9cb3d64c9187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863633003/1
3 years, 7 months ago (2017-05-04 20:20:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2a3f50f3684ccd28c4eb5160909a9cb3d64c9187
3 years, 7 months ago (2017-05-04 20:59:47 UTC) #6
johnme
3 years, 7 months ago (2017-05-05 10:57:34 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2858393004/ by johnme@chromium.org.

The reason for reverting is: This test immediately started flaking heavily on
the MSAN bots..

Powered by Google App Engine
This is Rietveld 408576698