Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2863633003: Reenable WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <queue> 5 #include <queue>
6 #include <set> 6 #include <set>
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 3121 matching lines...) Expand 10 before | Expand all | Expand 10 after
3132 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewCaptureTest, testing::Bool()); 3132 INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewCaptureTest, testing::Bool());
3133 3133
3134 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestZoomAPI) { 3134 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestZoomAPI) {
3135 TestHelper("testZoomAPI", "web_view/shim", NO_TEST_SERVER); 3135 TestHelper("testZoomAPI", "web_view/shim", NO_TEST_SERVER);
3136 } 3136 }
3137 3137
3138 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestFindAPI) { 3138 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestFindAPI) {
3139 TestHelper("testFindAPI", "web_view/shim", NO_TEST_SERVER); 3139 TestHelper("testFindAPI", "web_view/shim", NO_TEST_SERVER);
3140 } 3140 }
3141 3141
3142 // crbug.com/710486 3142 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestFindAPI_findupdate) {
3143 #if defined(MEMORY_SANITIZER)
3144 #define MAYBE_Shim_TestFindAPI_findupdate DISABLED_Shim_TestFindAPI_findupdate
3145 #else
3146 #define MAYBE_Shim_TestFindAPI_findupdate Shim_TestFindAPI_findupdate
3147 #endif
3148 IN_PROC_BROWSER_TEST_P(WebViewTest, MAYBE_Shim_TestFindAPI_findupdate) {
3149 TestHelper("testFindAPI_findupdate", "web_view/shim", NO_TEST_SERVER); 3143 TestHelper("testFindAPI_findupdate", "web_view/shim", NO_TEST_SERVER);
3150 } 3144 }
3151 3145
3152 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_testFindInMultipleWebViews) { 3146 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_testFindInMultipleWebViews) {
3153 TestHelper("testFindInMultipleWebViews", "web_view/shim", NO_TEST_SERVER); 3147 TestHelper("testFindInMultipleWebViews", "web_view/shim", NO_TEST_SERVER);
3154 } 3148 }
3155 3149
3156 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestLoadDataAPI) { 3150 IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestLoadDataAPI) {
3157 TestHelper("testLoadDataAPI", "web_view/shim", NEEDS_TEST_SERVER); 3151 TestHelper("testLoadDataAPI", "web_view/shim", NEEDS_TEST_SERVER);
3158 } 3152 }
(...skipping 981 matching lines...) Expand 10 before | Expand all | Expand 10 after
4140 ClosingChromeSignInShouldNotCrash) { 4134 ClosingChromeSignInShouldNotCrash) {
4141 GURL signin_url{"chrome://chrome-signin"}; 4135 GURL signin_url{"chrome://chrome-signin"};
4142 4136
4143 AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED); 4137 AddTabAtIndex(0, signin_url, ui::PAGE_TRANSITION_TYPED);
4144 AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED); 4138 AddTabAtIndex(1, signin_url, ui::PAGE_TRANSITION_TYPED);
4145 WaitForWebViewInDom(); 4139 WaitForWebViewInDom();
4146 4140
4147 chrome::CloseTab(browser()); 4141 chrome::CloseTab(browser());
4148 } 4142 }
4149 #endif 4143 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698