Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2863463002: Revert "Void is not required to be `null` anymore." (Closed)

Created:
3 years, 7 months ago by floitsch
Modified:
3 years, 7 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Void is not required to be `null` anymore." This reverts commit 4e52c457a9ac412b6b0a3a350020998c7e2f7d9a. BUG= Committed: https://github.com/dart-lang/sdk/commit/4b35d3995b2b273728751c19976ece0edca0eddc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -89 lines) Patch
M CHANGELOG.md View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 7 chunks +28 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/co19/co19-co19.status View 1 chunk +0 lines, -9 lines 0 comments Download
M tests/language/return_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/void_check_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
M tests/language/void_type_test.dart View 3 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
TBR.
3 years, 7 months ago (2017-05-03 17:21:44 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 4b35d3995b2b273728751c19976ece0edca0eddc (presubmit successful).
3 years, 7 months ago (2017-05-03 17:22:30 UTC) #4
jwren
3 years, 7 months ago (2017-05-03 17:38:44 UTC) #5
Message was sent while issue was closed. 
On 2017/05/03 17:22:30, floitsch wrote:
> Committed patchset #1 (id:1) manually as
> 4b35d3995b2b273728751c19976ece0edca0eddc (presubmit successful).

LGTM

Powered by Google App Engine
This is Rietveld 408576698