Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Side by Side Diff: runtime/vm/object.cc

Issue 2863463002: Revert "Void is not required to be `null` anymore." (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/become.h" 10 #include "vm/become.h"
(...skipping 15807 matching lines...) Expand 10 before | Expand all | Expand 10 after
15818 const AbstractType& other, 15818 const AbstractType& other,
15819 const TypeArguments& other_instantiator_type_arguments, 15819 const TypeArguments& other_instantiator_type_arguments,
15820 const TypeArguments& other_function_type_arguments, 15820 const TypeArguments& other_function_type_arguments,
15821 Error* bound_error) const { 15821 Error* bound_error) const {
15822 ASSERT(other.IsFinalized()); 15822 ASSERT(other.IsFinalized());
15823 ASSERT(!other.IsDynamicType()); 15823 ASSERT(!other.IsDynamicType());
15824 ASSERT(!other.IsTypeRef()); // Must be dereferenced at compile time. 15824 ASSERT(!other.IsTypeRef()); // Must be dereferenced at compile time.
15825 ASSERT(!other.IsMalformed()); 15825 ASSERT(!other.IsMalformed());
15826 ASSERT(!other.IsMalbounded()); 15826 ASSERT(!other.IsMalbounded());
15827 if (other.IsVoidType()) { 15827 if (other.IsVoidType()) {
15828 return true; 15828 return false;
15829 } 15829 }
15830 Zone* zone = Thread::Current()->zone(); 15830 Zone* zone = Thread::Current()->zone();
15831 const Class& cls = Class::Handle(zone, clazz()); 15831 const Class& cls = Class::Handle(zone, clazz());
15832 if (cls.IsClosureClass()) { 15832 if (cls.IsClosureClass()) {
15833 if (other.IsObjectType() || other.IsDartFunctionType() || 15833 if (other.IsObjectType() || other.IsDartFunctionType() ||
15834 other.IsDartClosureType()) { 15834 other.IsDartClosureType()) {
15835 return true; 15835 return true;
15836 } 15836 }
15837 AbstractType& instantiated_other = AbstractType::Handle(zone, other.raw()); 15837 AbstractType& instantiated_other = AbstractType::Handle(zone, other.raw());
15838 // Note that we may encounter a bound error in checked mode. 15838 // Note that we may encounter a bound error in checked mode.
(...skipping 7481 matching lines...) Expand 10 before | Expand all | Expand 10 after
23320 return UserTag::null(); 23320 return UserTag::null();
23321 } 23321 }
23322 23322
23323 23323
23324 const char* UserTag::ToCString() const { 23324 const char* UserTag::ToCString() const {
23325 const String& tag_label = String::Handle(label()); 23325 const String& tag_label = String::Handle(label());
23326 return tag_label.ToCString(); 23326 return tag_label.ToCString();
23327 } 23327 }
23328 23328
23329 } // namespace dart 23329 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | sdk/lib/_internal/js_runtime/lib/js_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698