pkg/compiler/lib/src/js_backend/impact_transformer.dart - Issue 2863463002: Revert "Void is not required to be `null` anymore."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/impact_transformer.dart

Issue 2863463002: Revert "Void is not required to be `null` anymore." (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/impact_transformer.dart

diff --git a/pkg/compiler/lib/src/js_backend/impact_transformer.dart b/pkg/compiler/lib/src/js_backend/impact_transformer.dart

index 1cb567c6ec38f90b2b70ec7b22353356ec9caab4..02393a1fee571d2d16ee5b632057953c69848b96 100644

--- a/pkg/compiler/lib/src/js_backend/impact_transformer.dart

+++ b/pkg/compiler/lib/src/js_backend/impact_transformer.dart

@@ -363,7 +363,6 @@ class CodegenImpactTransformer {

void onIsCheckForCodegen(DartType type, TransformedWorldImpact transformed) {

if (type.isDynamic) return;

- if (type.isVoid) return;

type = type.unaliased;

_impacts.typeCheck.registerImpact(transformed, _elementEnvironment);