Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2863433002: DevTools: Make domains promisified by default (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make domains promisified by default BUG=718063 Review-Url: https://codereview.chromium.org/2863433002 Cr-Commit-Position: refs/heads/master@{#469059} Committed: https://chromium.googlesource.com/chromium/src/+/7b92817323c7807efe8e95055af1386daddc7ce4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py View 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
alph
3 years, 7 months ago (2017-05-03 16:19:24 UTC) #2
dgozman
lgtm
3 years, 7 months ago (2017-05-03 17:01:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863433002/1
3 years, 7 months ago (2017-05-03 17:36:01 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:58:57 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b92817323c7807efe8e95055af1...

Powered by Google App Engine
This is Rietveld 408576698