Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py

Issue 2863433002: DevTools: Make domains promisified by default (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py
diff --git a/third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py b/third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py
index 38e9ebf6f25c67a9c6278fff24b45c2fd87cc8ae..624cdba12763d9ded812df25dc478bf396681f8c 100755
--- a/third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py
+++ b/third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py
@@ -46,9 +46,21 @@ type_traits = {
ref_types = {}
-PROMISIFIED_DOMAINS = frozenset([
- "HeapProfiler",
- "Profiler",
+NON_PROMISIFIED_DOMAINS = frozenset([
+ "Accessibility",
+ "Animation",
+ "ApplicationCache",
+ "CacheStorage",
+ "CSS",
+ "Debugger",
+ "DOM",
+ "DOMDebugger",
+ "IndexedDB",
+ "LayerTree",
+ "Network",
+ "Page",
+ "Runtime",
+ "Target",
])
@@ -122,7 +134,7 @@ def generate_protocol_externs(output_path, file1, file2):
for domain in domains:
domain_name = domain["domain"]
- is_promisified = domain_name in PROMISIFIED_DOMAINS
+ is_promisified = domain_name not in NON_PROMISIFIED_DOMAINS
output_file.write("Protocol.%s = {};\n" % domain_name)
output_file.write("\n\n/**\n * @constructor\n*/\n")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698