Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm

Issue 2863303002: Fixes a DCHECK in tools_menu_button_observer_bridge during tests (Closed)
Patch Set: fixed component_unittests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm
diff --git a/ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm b/ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm
index b7e76e78779f3c68fc5f44988c242d144ab05e09..e05fd68159f275a1c9cdc8856eb976843da4ad65 100644
--- a/ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm
+++ b/ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm
@@ -61,6 +61,10 @@
[self updateButtonWithModel:model];
}
+- (void)readingListModelBeingShutdown:(const ReadingListModel*)model {
+ DCHECK(model == _model);
+}
noyau (Ping after 24h) 2017/05/09 13:27:10 Is this method really necessary? In C++ this would
pkl (ping after 24h if needed) 2017/05/18 04:51:04 Removing this method since it is not doing anythin
+
- (void)readingListModelBeingDeleted:(const ReadingListModel*)model {
DCHECK(model == _model);
rohitrao (ping after 24h) 2017/05/09 14:52:08 Does anyone know why this DCHECK exists or what it
noyau (Ping after 24h) 2017/05/15 14:36:12 It's enforcing the fact that this method should on
pkl (ping after 24h if needed) 2017/05/18 04:51:04 This should really be here. After rebasing, I noti
_model = nullptr;

Powered by Google App Engine
This is Rietveld 408576698