components/reading_list/core/reading_list_model_unittest.cc - Issue 2863303002: Fixes a DCHECK in tools_menu_button_observer_bridge during tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/reading_list/core/reading_list_model_unittest.cc

Issue 2863303002: Fixes a DCHECK in tools_menu_button_observer_bridge during tests (Closed)

Patch Set: fixed component_unittests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/reading_list/core/reading_list_model_unittest.cc

diff --git a/components/reading_list/core/reading_list_model_unittest.cc b/components/reading_list/core/reading_list_model_unittest.cc

index a2b2b57fe4634fde0e989f6a97ed6bafd7cb0e2b..4db1b7b5413f71c0c4f0f53fbd095437c367be13 100644

--- a/components/reading_list/core/reading_list_model_unittest.cc

+++ b/components/reading_list/core/reading_list_model_unittest.cc

@@ -314,6 +314,7 @@ TEST_F(ReadingListModelTest, EmptyLoaded) {

EXPECT_EQ(0ul, ReadSize());

model_->Shutdown();

EXPECT_FALSE(model_->loaded());

+ model_.reset();

rohitrao (ping after 24h) 2017/05/09 14:52:08 Why does the model need to be reset here? This is

AssertObserverCount(1, 0, 0, 1, 0, 0, 0, 0, 0);

}