ios/chrome/browser/ui/omnibox_perftest.mm - Issue 2863303002: Fixes a DCHECK in tools_menu_button_observer_bridge during tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/omnibox_perftest.mm

Issue 2863303002: Fixes a DCHECK in tools_menu_button_observer_bridge during tests (Closed)

Patch Set: fixed component_unittests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/omnibox_perftest.mm

diff --git a/ios/chrome/browser/ui/omnibox_perftest.mm b/ios/chrome/browser/ui/omnibox_perftest.mm

index 69e0b80f6bfdb438679675a321308da81decefcb..d5bfe8befc9fbf8b58a87e4715806f54ce0f5269 100644

--- a/ios/chrome/browser/ui/omnibox_perftest.mm

+++ b/ios/chrome/browser/ui/omnibox_perftest.mm

@@ -215,8 +215,7 @@ class OmniboxPerfTest : public PerfTest {

// Measures the amount of time it takes the Omnibox text field to activate

// the on-screen keyboard.

-// TODO(crbug.com/717300): Test disabled because of a DCHECK in Reading List.

-TEST_F(OmniboxPerfTest, DISABLED_TestTextFieldDidBeginEditing) {

+TEST_F(OmniboxPerfTest, TestTextFieldDidBeginEditing) {

LogPerfTiming("Keyboard preload", PreLoadKeyboard());

OmniboxTextFieldIOS* textField = (OmniboxTextFieldIOS*)FindViewByClass(

[toolbar_ view], [OmniboxTextFieldIOS class]);