Chromium Code Reviews
Help | Chromium Project | Sign in
(115)

Issue 28633002: Fix compilation error of public/platform/WebFloatRect.h for MSVC 2013 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by Yoshi
Modified:
6 months, 1 week ago
Reviewers:
tkent, morrita1, abarth
CC:
blink-reviews_chromium.org, jamesr (out of office), dglazkov+blink_chromium.org, abarth
Visibility:
Public.

Description

Fix compilation error of public/platform/WebFloatRect.h for MSVC 2013

This patch fixes compilation error of public/platform/WebFloatRect.h for MSVC 2013.

Error message on MSVC 2013:
d:\src\w\cr\src\third_party\webkit\public\platform\webfloatrect.h(111) : error C2039: 'max' : is not a member of 'std'

BUG=n/a
TEST=n/a; no behavior changes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159999

Patch Set 1 #

Patch Set 2 : 2013-10-18T19:02:58 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Lint Patch
M public/platform/WebFloatRect.h View 1 1 chunk +1 line, -0 lines 0 comments 1 errors Download
Commit:

Messages

Total messages: 6
Yoshi
Could you review this patch? Thanks in advance.
6 months, 1 week ago #1
tkent
> d:\src\w\cr\src\third_party\webkit\public\platform\webfloatrect.h(111) : error C2039: 'max' : is not a member of 'std' What .cpp/.cc ...
6 months, 1 week ago #2
Yoshi
PTAL Compilation error is occurred in src/third_party/WebKit/Source/testing/runner/TestPlugin.cpp. So, I move #include <algorithm> into non-blink implementation ...
6 months, 1 week ago #3
abarth
lgtm
6 months, 1 week ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/28633002/50001
6 months, 1 week ago #5
I haz the power (commit-bot)
6 months, 1 week ago #6
Message was sent while issue was closed.
Change committed as 159999
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6