Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2862953002: exo: Fix multi-display cursor crash (Closed)

Created:
3 years, 7 months ago by Dominik Laskowski
Modified:
3 years, 7 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Fix multi-display cursor crash The cursor surface is parented to the primary root window, which may change when using multiple displays. This CL fixes a crash caused by removing the child from the primary root window when the parent is a different root window or the child is orphaned. BUG=714832 TEST=No crashes after changing primary display. Review-Url: https://codereview.chromium.org/2862953002 Cr-Commit-Position: refs/heads/master@{#469543} Committed: https://chromium.googlesource.com/chromium/src/+/8d03afaa6214f583f526587f3865b4ccad45cad3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M components/exo/pointer.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Dominik Laskowski
PTAL.
3 years, 7 months ago (2017-05-04 21:10:25 UTC) #2
reveman
lgtm
3 years, 7 months ago (2017-05-04 21:12:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862953002/1
3 years, 7 months ago (2017-05-05 00:21:40 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 00:28:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d03afaa6214f583f526587f3865...

Powered by Google App Engine
This is Rietveld 408576698