Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2860863004: exo: Confine windows to primary display (Closed)

Created:
3 years, 7 months ago by Dominik Laskowski
Modified:
3 years, 7 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Confine windows to primary display Multi-display support in ARC was punted to the next milestone. This CL temporarily prevents windows from being dragged to secondary displays by using display rather than screen coordinates for window bounds. BUG=714832 TEST=ARC apps cannot be dragged to secondary displays. Review-Url: https://codereview.chromium.org/2860863004 Cr-Commit-Position: refs/heads/master@{#469514} Committed: https://chromium.googlesource.com/chromium/src/+/53f36cb4e8b4301b733e64d392769ee3ab9a5ca8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M components/exo/shell_surface.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/exo/wm_helper_ash.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Dominik Laskowski
PTAL.
3 years, 7 months ago (2017-05-04 21:10:04 UTC) #2
reveman
This affects non-arc windows too, right? Is that what we want?
3 years, 7 months ago (2017-05-04 21:11:46 UTC) #3
reveman
lgtm with nit https://codereview.chromium.org/2860863004/diff/1/components/exo/wm_helper_ash.cc File components/exo/wm_helper_ash.cc (right): https://codereview.chromium.org/2860863004/diff/1/components/exo/wm_helper_ash.cc#newcode63 components/exo/wm_helper_ash.cc:63: return ash::Shell::GetContainer(ash::Shell::GetPrimaryRootWindow(), nit: please add a ...
3 years, 7 months ago (2017-05-04 21:56:11 UTC) #6
Dominik Laskowski
https://codereview.chromium.org/2860863004/diff/1/components/exo/wm_helper_ash.cc File components/exo/wm_helper_ash.cc (right): https://codereview.chromium.org/2860863004/diff/1/components/exo/wm_helper_ash.cc#newcode63 components/exo/wm_helper_ash.cc:63: return ash::Shell::GetContainer(ash::Shell::GetPrimaryRootWindow(), On 2017/05/04 21:56:11, reveman wrote: > nit: ...
3 years, 7 months ago (2017-05-04 22:42:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860863004/20001
3 years, 7 months ago (2017-05-04 22:44:38 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 23:25:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53f36cb4e8b4301b733e64d39276...

Powered by Google App Engine
This is Rietveld 408576698