Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2862923002: More cleanups on the CanvasRenderingContextHost front (Closed)

Created:
3 years, 7 months ago by fserb
Modified:
3 years, 7 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, Rik, chromium-reviews, dshwang, haraken, Justin Novosad
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

More cleanups on the CanvasRenderingContextHost front - move more things to the interface - make offscreencanvas() only available for bindings BUG= Review-Url: https://codereview.chromium.org/2862923002 Cr-Commit-Position: refs/heads/master@{#469500} Committed: https://chromium.googlesource.com/chromium/src/+/d85bd254f744e08de01638771725930bdac850ef

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h View 2 chunks +1 line, -2 lines 1 comment Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
fserb
3 years, 7 months ago (2017-05-04 19:46:58 UTC) #2
Justin Novosad
lgtm with nit https://codereview.chromium.org/2862923002/diff/1/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h File third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h (right): https://codereview.chromium.org/2862923002/diff/1/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h#newcode40 third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h:40: OffscreenCanvas* offscreenCanvasForBinding() const { Nit: Binding ...
3 years, 7 months ago (2017-05-04 20:55:24 UTC) #3
fserb
On 2017/05/04 at 20:55:24, junov wrote: > lgtm with nit > > https://codereview.chromium.org/2862923002/diff/1/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h > File ...
3 years, 7 months ago (2017-05-04 20:57:59 UTC) #4
fserb
3 years, 7 months ago (2017-05-04 20:58:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862923002/1
3 years, 7 months ago (2017-05-04 20:59:04 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 22:53:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d85bd254f744e08de01638771725...

Powered by Google App Engine
This is Rietveld 408576698