third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h - Issue 2862923002: More cleanups on the CanvasRenderingContextHost front

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

Issue 2862923002: More cleanups on the CanvasRenderingContextHost front (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp ('k') | third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

index 1f994a34aecebcf366194bba3ee2b09f4c45314e..23a04d958e3543112f4c5b8ce69e2e801acb4e59 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

@@ -37,7 +37,7 @@ class MODULES_EXPORT OffscreenCanvasRenderingContext2D final

}

};

- OffscreenCanvas* offscreenCanvas() const {

+ OffscreenCanvas* offscreenCanvasForBinding() const {

Justin Novosad 2017/05/04 20:55:24 Nit: Binding -> Bindings

DCHECK(!host() || host()->IsOffscreenCanvas());

return static_cast<OffscreenCanvas*>(host());

}

@@ -119,7 +119,6 @@ class MODULES_EXPORT OffscreenCanvasRenderingContext2D final

CanvasPixelFormat PixelFormat() const override;

};

-// TODO(fserb): remove this.

DEFINE_TYPE_CASTS(OffscreenCanvasRenderingContext2D,

CanvasRenderingContext,

context,