Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2862563002: [heap] Pause black allocation during GCs (Closed)

Created:
3 years, 7 months ago by Michael Lippautz
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Pause black allocation during GCs There is no point in doing black allocation here as we then have to iterate the objects for various reasons. The marker does the same work but can be moved outside of the atomic pause. BUG=chromium:581412 Review-Url: https://codereview.chromium.org/2862563002 Cr-Commit-Position: refs/heads/master@{#45063} Committed: https://chromium.googlesource.com/v8/v8/+/17a0a575a3795141dfccabc688b3fa39f226e186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -40 lines) Patch
M src/heap/heap.h View 3 chunks +5 lines, -9 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +8 lines, -18 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +4 lines, -9 lines 0 comments Download
M src/heap/incremental-marking.h View 2 chunks +22 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/heap/scavenger.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Michael Lippautz
ptal
3 years, 7 months ago (2017-05-03 12:35:44 UTC) #2
payer
lgtm
3 years, 7 months ago (2017-05-03 12:53:54 UTC) #6
Hannes Payer (out of office)
lgtm
3 years, 7 months ago (2017-05-03 13:02:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862563002/1
3 years, 7 months ago (2017-05-03 13:57:04 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 13:58:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/17a0a575a3795141dfccabc688b3fa39f22...

Powered by Google App Engine
This is Rietveld 408576698