Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: src/heap/heap.h

Issue 2862563002: [heap] Pause black allocation during GCs (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index f8f2ec16ed5d08eb2554d4981bb313f8a5960082..c43d3219c82800c6fdbb59bf6b4c5ac6c776bbee 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -434,9 +434,8 @@ class PromotionQueue {
inline void SetNewLimit(Address limit);
inline bool IsBelowPromotionQueue(Address to_space_top);
- inline void insert(HeapObject* target, int32_t size, bool was_marked_black);
- inline void remove(HeapObject** target, int32_t* size,
- bool* was_marked_black);
+ inline void insert(HeapObject* target, int32_t size);
+ inline void remove(HeapObject** target, int32_t* size);
bool is_empty() {
return (front_ == rear_) &&
@@ -445,12 +444,10 @@ class PromotionQueue {
private:
struct Entry {
- Entry(HeapObject* obj, int32_t size, bool was_marked_black)
- : obj_(obj), size_(size), was_marked_black_(was_marked_black) {}
+ Entry(HeapObject* obj, int32_t size) : obj_(obj), size_(size) {}
HeapObject* obj_;
- int32_t size_ : 31;
- bool was_marked_black_ : 1;
+ int32_t size_;
};
inline Page* GetHeadPage();
@@ -1215,8 +1212,7 @@ class Heap {
void IterateWeakRoots(RootVisitor* v, VisitMode mode);
// Iterate pointers of promoted objects.
- void IterateAndScavengePromotedObject(HeapObject* target, int size,
- bool was_marked_black);
+ void IterateAndScavengePromotedObject(HeapObject* target, int size);
// ===========================================================================
// Store buffer API. =========================================================
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698